Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3{11,12}Packages.nose: drop #348699

Merged
merged 4 commits into from
Oct 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions nixos/doc/manual/release-notes/rl-2411.section.md
Original file line number Diff line number Diff line change
Expand Up @@ -597,6 +597,9 @@
lists by default. Backwards-compatible behavior can be enabled with
`atomsCoercedToLists`.

- `python3Packages.nose` has been removed, as it has been deprecated and unmaintained for almost a decade and does not work on Python 3.12.
Please switch to `pytest` or another test runner/framework.

## Other Notable Changes {#sec-release-24.11-notable-changes}

<!-- To avoid merge conflicts, consider adding your item at an arbitrary place in the list instead. -->
Expand Down
576 changes: 0 additions & 576 deletions pkgs/development/python-modules/nose/0001-nose-python-3.12-fixes.patch

This file was deleted.

63 changes: 0 additions & 63 deletions pkgs/development/python-modules/nose/default.nix

This file was deleted.

16 changes: 6 additions & 10 deletions pkgs/development/python-modules/nose2pytest/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@
fetchpatch2,
setuptools,
fissix,
pytestCheckHook,
nose,
pytest,
}:

let
Expand Down Expand Up @@ -37,16 +36,13 @@ buildPythonPackage {

build-system = [ setuptools ];

dependencies = [ fissix ];

nativeCheckInputs = [
pytestCheckHook
nose
dependencies = [
fissix
pytest
];

preCheck = ''
export HOME=$(mktemp -d)
'';
# Tests depend on nose!
doCheck = false;

pythonImportsCheck = [ "nose2pytest.assert_tools" ];

Expand Down
2 changes: 0 additions & 2 deletions pkgs/development/python-modules/pytest/7.nix
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
argcomplete,
hypothesis,
mock,
nose,
pygments,
requests,
xmlschema,
Expand Down Expand Up @@ -66,7 +65,6 @@ let
attrs
hypothesis
mock
nose
pygments
requests
setuptools
Expand Down
1 change: 1 addition & 0 deletions pkgs/top-level/python-aliases.nix
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,7 @@ mapAliases ({
net2grid = gridnet; # add 2022-04-22
nghttp2 = throw "in 1.52.0 removed deprecated python bindings."; # added 2023-06-08
ninja-python = ninja; # add 2022-08-03
nose = throw "nose has been removed since it has been deprecated and unmaintained for almost a decade and does not work on Python 3.12; please switch to pytest or another test runner/framework"; # added 2024-07-28
nose3 = throw "nose3 has been removed since it is unmaintained and does not work with Python 3.12"; # added 2024-07-28
nosejs = throw "nosejs has been removed since it has not been maintained for 15 years and there are no dependent packages"; # added 2024-05-21
nose-cov = throw "nose-cov has been removed, it was archived and unmaintained since 2012"; # added 2024-05-21
Expand Down
2 changes: 0 additions & 2 deletions pkgs/top-level/python-packages.nix
Original file line number Diff line number Diff line change
Expand Up @@ -9027,8 +9027,6 @@ self: super: with self; {

normality = callPackage ../development/python-modules/normality { };

nose = callPackage ../development/python-modules/nose { };

nose2 = callPackage ../development/python-modules/nose2 { };

nose2pytest = callPackage ../development/python-modules/nose2pytest { };
Expand Down