[24.05] linux_xanmod: backport small refactor to allow clean backports #348702
+12
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
988bf19 (among other things) refactored this expression a little. This made backports no longer apply cleanly, requiring manual backports which are tedious. This commit backports only the part that refactors the version declaration in order to make automated backports work again. (The `variant` variable was unused.) This is technically a refactor which shouldn't typically be backported but the change is very minor and trivial to verify to be correct.
Atemu
changed the title
moni-dz
approved these changes
Oct 15, 2024
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
988bf19 (among other things) refactored this expression a little. This made backports no longer apply cleanly, requiring manual backports which are tedious.
This commit backports only the part that refactors the version declaration in order to make automated backports work again.
(The
variantvariable was unused.)This is technically a refactor which shouldn't typically be backported but the change is very minor and trivial to verify to be correct.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.