erlang: 25.3.2.13 -> 25.3.2.15, erlang_26: 26.2.5.1 -> 26.2.5.4, erlang_27: 27.0.1 -> 27.1.2 #349428
+8
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chiroptical
changed the title
|
DON'T MERGE THIS UNTIL ALL TESTS PASS (sorry for yelling but last time someone merged before all the tests passed on |
chiroptical
force-pushed
the
chiroptical/otp-updates
branch
from
534e0a5
to
e7d44d6
Compare
|
@jcowgar for reference |
chiroptical
force-pushed
the
chiroptical/otp-updates
branch
2 times, most recently
from
f66d03f
to
9f46677
Compare
chiroptical
commented
Oct 18, 2024
chiroptical
force-pushed
the
chiroptical/otp-updates
branch
from
9f46677
to
60d0038
Compare
chiroptical
commented
Oct 18, 2024
Comment on lines
+101
to
+102
| LANG = "C.UTF-8"; | ||
|
|
There was a problem hiding this comment.
Without this ex_doc behaves very strangely. I don't see any issue with setting this always?
ofborg
bot
requested review from
minijackson,
yurrriq,
ankhers,
Br1ght0ne,
gleber,
DianaOlympos and
happysalada
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains updates to OTP for 25, 26, 27
Note: when running
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"on my OSX (aarch64-darwin) machine I wasn't able to build https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/servers/pleroma/default.nix due to a dependency calledvixwhich is a NIF wrapper aroundlibvips. However, I can't build any of these packages onmasteron the same machine so AFAICT they are broken on OSX.Running this same command on my Linux machine (x86_64-linux):
mercuryfails to compile with GCC bug. I don't think that is something I will try to fix.mercuryis also a dependency ofnotmuch-bowerso I wasn't able to build that either.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.