nixos/eval-config: Deprecate NIXOS_EXTRA_MODULE_PATH #349549
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roberth
force-pushed
the
deprecate-NIXOS_EXTRA_MODULE_PATH
branch
from
2120ee7
to
9d9a572
Compare
This gets rid of a potentially confusing behavior that doesn't need to
be in NixOS, and nobody ever bothered to add a test for it.
Let's keep things simple!
The suggested snippet is better than this feature ever was, and will be
in the user's face, where it belongs, kindly.
Tested with
nix-instantiate nixos/lib/eval-config.nix --arg modules '[{fileSystems."/".device="x";boot.loader.grub.enable=false;}]' -A config.system.build.toplevel
NIXOS_EXTRA_MODULE_PATH=$HOME/whatever.nix nix-instantiate nixos/lib/eval-config.nix --arg modules '[{fileSystems."/".device="x";boot.loader.grub.enable=false;}]' -A config.system.build.toplevel
roberth
force-pushed
the
deprecate-NIXOS_EXTRA_MODULE_PATH
branch
from
9d9a572
to
5f197bf
Compare
|
I initially wrongly claimed this variable wasn't documented; that's I still need to evaluate what to do with that. It's not as easy to remove, so maybe we shouldn't. Instead unify with |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
getEnvis just no good for Nix-style configuration management, even if you're not using pure mode or flakes.Description
This gets rid of a potentially confusing behavior that doesn't need to be in NixOS, and nobody ever bothered to write a test for it. Let's keep things simple!
The suggested snippet is better than this feature ever was, and will be in the user's face, where it belongs, kindly.
Tested with
I'm not adding a release note, because whoever needs to read about this will do so when they evaluate their upgrade.
No need to bother other users with it.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.