libtatsu: init, libimobiledevice-drvs: update all with minor rebuilds #349567
+214
−129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Drafting to perform a minor version bump on all of these derivations, including rebasing to the current master |
13 tasks
Frontear
force-pushed
the
init-libtatsu-and-update-minor-libimobiledevice-drvs
branch
from
205c16e
to
78011da
Compare
|
| ]; | ||
|
|
||
| # the package uses zip_get_num_entries, which is deprecated | ||
| env.NIX_CFLAGS_COMPILE = toString [ | ||
| NIX_CFLAGS_COMPILE = toString [ |
There was a problem hiding this comment.
Suggested change
| NIX_CFLAGS_COMPILE = toString [ | |
| env.NIX_CFLAGS_COMPILE = toString [ |
There was a problem hiding this comment.
Whoops, seems I've made a change that isn't the best. Could I ask why this is preferred? Afaict both will propagate as an env var for the derivation. Is this preferred due to its more explicit use of "env" to imply "as an env var"?
EDIT: fixed!
Frontear
force-pushed
the
init-libtatsu-and-update-minor-libimobiledevice-drvs
branch
from
78011da
to
4639e34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a separation commit from #342961 targetting all derivations that result in minor rebuilds. The maximum rebuilds I have observed from these are 33.
These changes were accompanied by cleanup that is shared between both PRs. Cleanup includes:
unstableGitUpdaterto all derivations (see explanation by @restoration578 here)meta.licensemore consistently to upstreammeta.homepageplatforms.unixfor all derivations inmeta.platformspkgs/by-namecc @restoration578 @clebs @RossComputerGuy @winterqt as commentors from the previous pr.
Relevant Issues
Closes #342738
Closes #342736
Closes #342731
Closes #342728
Closes #342729
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.