stdenvAdapters.extendMkDerivationArgs: move from let-in #350350
Draft
+25
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expose the previously internal extendMkDerivationArgs as a stdenv adapter for out-of-tree use
SomeoneSerge
force-pushed
the
feat/extendMkDerivationArgsAdapter
branch
from
439bb1d to
3a78ad6
Compare
SomeoneSerge
commented
Oct 21, 2024
| requestCcache = extendMkDerivationArgs | ||
| (oldAttrs: { requiredSysteFeatures = oldAttrs.requiredSysteFeatures or [ ] ++ [ "ccache" ]; }); | ||
| */ | ||
| extendMkDerivationArgs = |
There was a problem hiding this comment.
Fwiw overrideMkDerivationArgs would have been a more honest name
There was a problem hiding this comment.
Hmmm, I think you're right. Internally since extension is passed to overrideAttrs, it's a more descriptive name which hopefully indicates extension can be of the form final: prev: blarg.
ofborg
bot
added
10.rebuild-darwin: 0
ConnorBaker
reviewed
Oct 31, 2024
|
|
||
|
|
||
| /* Use the trace output to report all processed derivations with their | ||
| license name. | ||
| licen:se name. |
| requestCcache = extendMkDerivationArgs | ||
| (oldAttrs: { requiredSysteFeatures = oldAttrs.requiredSysteFeatures or [ ] ++ [ "ccache" ]; }); | ||
| */ | ||
| extendMkDerivationArgs = |
There was a problem hiding this comment.
Hmmm, I think you're right. Internally since extension is passed to overrideAttrs, it's a more descriptive name which hopefully indicates extension can be of the form final: prev: blarg.
wegank
added
the
2.status: merge conflict
|
Marking as draft until merge conflicts are resolved. Please ping me when ready again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #306953 but also I needed this to play with ccache
CC @Ericson2314 who I think authored the piece?
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.