Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sage: work around glpk aarch64 issue instead of disabling test #351248

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

collares
Copy link
Member

@collares collares commented Oct 25, 2024

The issue at sagemath/sage#34575 now has a workaround at sagemath/sage#38851. Looks like ofBorg is happy with it.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@collares collares marked this pull request as ready for review October 26, 2024 19:11
@7c6f434c
Copy link
Member

Hmmm, so does this cause a new genuine failure on aarch64-linux?

@collares
Copy link
Member Author

Thanks for checking! In this case, it's just an old intermittent test failure in Sage: sagemath/sage#30419

@7c6f434c 7c6f434c merged commit 9ec0e7c into NixOS:master Oct 29, 2024
39 of 40 checks passed
@collares
Copy link
Member Author

collares commented Nov 1, 2024

My bad, that's actually another intermittent failure on the same file, but for some reason it seems to happen much more often now. Will import the patch at sagemath/sage#38628.

Edit: #352810.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants