Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.glances-api: disable failing test #352978

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Nov 1, 2024

ZHF: #352882

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@fabaff fabaff added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label Nov 1, 2024
@fabaff
Copy link
Member Author

fabaff commented Nov 1, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 352978


x86_64-linux

✅ 5 packages built:
  • home-assistant-component-tests.glances
  • python311Packages.glances-api
  • python311Packages.glances-api.dist
  • python312Packages.glances-api
  • python312Packages.glances-api.dist

@tjni
Copy link
Contributor

tjni commented Nov 1, 2024

Do you intend to delete or fix this test upstream?

I'm guessing that the error is happening because of changes in pytest-httpx between 0.30 and 0.32, maybe one of these two:

  • Last registered matching response will not be reused by default anymore in case all matching responses have already been sent.
    • This behavior can be changed thanks to the new pytest.mark.httpx_mock(can_send_already_matched_responses=True) option.
    • The incentive behind this change is to spot regression if a request was issued more than the expected number of times.
  • Tests will now fail at teardown by default if some requests were issued but were not matched.
    • This behavior can be changed thanks to the new pytest.mark.httpx_mock(assert_all_requests_were_expected=False) option.
    • The incentive behind this change is to spot unexpected requests in case code is swallowing httpx.TimeoutException.

(from https://github.com/Colin-b/pytest_httpx/blob/master/CHANGELOG.md#0320---2024-09-27)

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Nov 2, 2024
@wegank wegank marked this pull request as draft November 10, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants