wings: format via nixfmt; bump to 2.3 #354534
Open
+40
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
alyssais
reviewed
Nov 8, 2024
| # The following lines were added during an update to 2.3 due to changes to the Makefile. Chances are | ||
| # there are better ways to do this, but I'm not aware if there are. PRs welcome. | ||
| # Remove any targets that depend on these dependencies (e.g., c_src) | ||
| find . -type f -name "Makefile" -exec sed -i 's,c_src: $(DEPS),c_src:,g' {} \; |
There was a problem hiding this comment.
Maybe you can just set DEPS= in makeFlags for this one?
There was a problem hiding this comment.
I completely forgot about this, good catch. I'll see what I can do.
ofborg
bot
added
10.rebuild-darwin: 0
Kek5chen
suggested changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Wings from 2.2.4 to 2.3. Contains a few hacks, so reviews appreciated.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.