ocamlPackages.dune-configurator: workaround clang arg order bug #356054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reorder compiler arguments so the c code file name is last. this works around a bug in clang which can indicate the compiler supports an argument when it does not. `https://github.com/ocaml/dune/pull/11123` `https://github.com/llvm/llvm-project/issues/116278`
paparodeo
force-pushed
the
ocamlstuff
branch
from
c38244f
to
40018ec
Compare
|
this doesn't work for non-wrapped gcc which requires the lib after the file name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reorder compiler arguments so the c code file name is last. this works around a bug in clang which can indicate the compiler supports an argument when it does not.
ocaml/dune#11123
llvm/llvm-project#116278
this will allow various ocaml modules to build using clang-17 and greater.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.