treewide: improve prepending and appending derivation arguments in bash code #357052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: python
6.topic: haskell
6.topic: qt/kde
6.topic: TeX
nix-owners
bot
requested review from
K900,
maralorn,
mweinelt,
natsukium,
NickCao,
philiptaron,
sternenseemann,
SuperSandro2000 and
ttuegel
|
BTW, something that was pointed out to me is that |
2 tasks
ofborg
bot
added
10.rebuild-linux-stdenv
|
I went through this PR line-by-line again, LGTM. Can't approve myself, though ;) |
wolfgangwalther
force-pushed
the
structured-attrs-flag-handling-staging
branch
2 times, most recently
from
9444c3b to
1c2a5af
Compare
|
No idea why Outpaths (aarch64-darwin) suddenly fails after rebasing. |
This had been resolved in NixOS#318226.
wolfgangwalther
force-pushed
the
structured-attrs-flag-handling-staging
branch
from
1c2a5af to
f81eada
Compare
Just running it once more fixed it. |
@emilazy in case you are ok with this PR as well: ofborg-eval passed. |
ShamrockLee
reviewed
Nov 24, 2024
Mindavi
reviewed
Nov 25, 2024
Mindavi
approved these changes
Nov 25, 2024
wolfgangwalther
force-pushed
the
structured-attrs-flag-handling-staging
branch
from
f81eada to
801fe2c
Compare
…sh code Those would be problematic with __structuredAttrs turned on, because they'd turn those nice bash arrays back into strings - and potentially lose some of the values on the way.
wolfgangwalther
force-pushed
the
structured-attrs-flag-handling-staging
branch
from
801fe2c to
d86588d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those would be problematic with __structuredAttrs turned on, because they'd turn those nice bash arrays back into strings - and potentially lose some of the values on the way.
Part of the overall effort to enable structuredAttrs by default eventually, tracking: #205690
I think those changes are straight-forward, but somebody better double check.
@ShamrockLee @emilazy
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.