-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.pygerber: init at 2.4.2 #359437
base: master
Are you sure you want to change the base?
Conversation
do I need to do anything else? Sorry it's my first PR so I'm not sure. @steeleduncan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not familiar enough with python derivations to leave an approving review, but I certainly wouldn't want to block it
If you can find someone who has merged some python commits recently and ping them for a review that is probably the best approach to get it merged
@natsukium Hello, hope it's ok for me to ping you here. I opened this PR about 3 weeks ago and I wasn't sure if I had to do anything else to get it merged. |
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.