Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci/eval: test aliases #360242

Merged
merged 1 commit into from
Dec 3, 2024
Merged

ci/eval: test aliases #360242

merged 1 commit into from
Dec 3, 2024

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Nov 29, 2024 •
edited
Loading

Aliases do not add new packages, so basic evaluation with nix-env should be enough and fairly quick. We only need one system because aliases should be the same on all platforms.

Mic92#40

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: policy discussion 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions labels Nov 29, 2024
@Mic92 Mic92 requested a review from infinisil November 29, 2024 21:59
Mic92
Mic92 commented Nov 29, 2024
View reviewed changes
.github/workflows/eval.yml Outdated Show resolved Hide resolved
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 30, 2024
@Mic92 Mic92 mentioned this pull request Dec 1, 2024
Open
6 tasks
@Mic92
ci/eval: test aliases
b473547 
Aliases do not add new packages, so basic evaluation with nix-env should
be enough and fairly quick.
@Mic92 Mic92 merged commit 8166227 into NixOS:master Dec 3, 2024
28 checks passed
@Mic92 Mic92 deleted the ci-aliases branch December 3, 2024 06:46
@JohnRTitor JohnRTitor added the backport release-24.11 Backport PR automatically label Dec 3, 2024
@nix-backports
Copy link

nix-backports bot commented Dec 3, 2024

Git push to origin failed for release-24.11 with exitcode 1

@JohnRTitor JohnRTitor mentioned this pull request Dec 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asymmetric asymmetric asymmetric left review comments

@infinisil infinisil Awaiting requested review from infinisil

@azuwis azuwis Awaiting requested review from azuwis

@LeSuisse LeSuisse Awaiting requested review from LeSuisse

@mweinelt mweinelt Awaiting requested review from mweinelt

@risicle risicle Awaiting requested review from risicle

@zowoq zowoq Awaiting requested review from zowoq

Assignees
No one assigned
Labels
6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: policy discussion 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mic92 @asymmetric @JohnRTitor