-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added dotnet-ef - the core tool of .NET Entity Framework #361198
Conversation
The only problem I see here is that the commit messages are non-standard. The new package should be Same goes for the other PR you mentioned, but we might as well finish one of them and rebase the other to remove the maintainer commit. |
4c24080
to
3125cd1
Compare
@corngood reworded commits |
Thanks! I see there's a 9.0.0 version on nuget.org. Are these tied to runtime / SDK versions? I'm just trying to understand if we'd need both 8+9, and if not, when we would want to move to 9. |
|
3125cd1
to
0d86099
Compare
@corngood I tried to upgrade and even though my system does not have .NET 9 the 9.0.0 worked, so I bumped the version. My original reasoning was to stay on the LTS side just in case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks.
- the core tool of .NET Entity Framework
0d86099
to
4831293
Compare
Successfully created backport PR for |
https://learn.microsoft.com/en-us/ef/core/cli/dotnet
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.