Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dotnet-ef - the core tool of .NET Entity Framework #361198

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

lostmsu
Copy link
Contributor

@lostmsu lostmsu commented Dec 2, 2024

https://learn.microsoft.com/en-us/ef/core/cli/dotnet

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 2, 2024
@lostmsu
Copy link
Contributor Author

lostmsu commented Dec 2, 2024

@mdarocha @corngood tagging you guys as you seem to be interested in .NET on NixOS

Also a very similar PR for another less popular .NET tool (DBus binding generator): #360047

@corngood
Copy link
Contributor

corngood commented Dec 2, 2024

The only problem I see here is that the commit messages are non-standard. The new package should be [package name]: init at [version], and the maintainer commit should probably be prefixed with the module name. Take a look at the history of that file for guidance.

Same goes for the other PR you mentioned, but we might as well finish one of them and rebase the other to remove the maintainer commit.

@lostmsu
Copy link
Contributor Author

lostmsu commented Dec 2, 2024

@corngood reworded commits

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 2, 2024
@corngood
Copy link
Contributor

corngood commented Dec 2, 2024

Thanks! I see there's a 9.0.0 version on nuget.org. Are these tied to runtime / SDK versions? I'm just trying to understand if we'd need both 8+9, and if not, when we would want to move to 9.

@corngood
Copy link
Contributor

corngood commented Dec 2, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 361198


x86_64-linux

✅ 1 package built:
  • dotnet-ef

@lostmsu
Copy link
Contributor Author

lostmsu commented Dec 3, 2024

@corngood I tried to upgrade and even though my system does not have .NET 9 the 9.0.0 worked, so I bumped the version.

My original reasoning was to stay on the LTS side just in case.

@corngood corngood self-requested a review December 3, 2024 01:17
Copy link
Contributor

@corngood corngood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1 10.rebuild-linux: 1 labels Dec 3, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 3, 2024
 - the core tool of .NET Entity Framework
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 5, 2024
@corngood corngood merged commit f286684 into NixOS:master Dec 5, 2024
19 of 20 checks passed
@corngood corngood added the backport release-24.11 Backport PR automatically label Dec 5, 2024
@nix-backports
Copy link

nix-backports bot commented Dec 5, 2024

Successfully created backport PR for release-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants