Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux kernel: increase build timeout from 2 to 4 hrs #47564

Merged
merged 1 commit into from
Oct 1, 2018
Merged

linux kernel: increase build timeout from 2 to 4 hrs #47564

merged 1 commit into from
Oct 1, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Sep 30, 2018

Motivation for this change

We've recently seen a many kernel build timeouts on hydra like this: https://hydra.nixos.org/eval/1481520?filter=linuxPackage so let's increase the timeout.
We'll see if 4 hours are sufficient (hey, it's a lot faster than chromium builds 😄)

Please backport to 18.09, ZHF #45960.

Things done
  • noop, just increased timeout

cc @vcunat @samueldr @thoughtpolice

@xeji
linux kernel: increase build timeout from 2 to 4 hrs
f644e29 
We've recently seen a lot of kernel build timeouts on hydra,
so let's increase the timeout.
vcunat
vcunat approved these changes Sep 30, 2018
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe there's some sub-optimal setting around the aarch64 builders, but this PR is easy and seems very unlikely to hurt anything.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Sep 30, 2018
@samueldr samueldr mentioned this pull request Oct 1, 2018
Closed
@xeji xeji merged commit 83fd978 into NixOS:master Oct 1, 2018
@xeji xeji deleted the p/kernel-timeout branch October 1, 2018 15:40
xeji added a commit that referenced this pull request Oct 1, 2018
@xeji
linux kernel: increase build timeout from 1hr to 4 hrs (#47564)
10eec00 
We've recently seen a lot of kernel build timeouts on hydra,
so let's increase the timeout.

(cherry picked from commit 83fd978 and
resolved conflict)
@xeji
Copy link
Contributor Author

xeji commented Oct 1, 2018

backported in 10eec00.

@vcunat @samueldr on 18.09, previous timeout was still the default 1 hour, which may explain the aarch64 issues. It had been increased to 2hrs on master before.

@xeji xeji mentioned this pull request Oct 1, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xeji @vcunat @GrahamcOfBorg