nodejs: init at 11.5.0 #48911

lo1tuma · 2018-10-23T19:25:34Z

Motivation for this change

New major release of nodejs.
Release Notes.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

adisbladis · 2018-10-24T13:01:57Z

@GrahamcOfBorg build nodejs-11_x

GrahamcOfBorg · 2018-10-24T13:06:10Z

Failure on aarch64-linux (full log)

Attempted: nodejs-11_x

Partial log (click to expand)

installing /nix/store/xzv8mkyw5bnqfb2gxwsr7kqmzlzcksyg-nodejs-11.0.0/lib/node_modules/npm/node_modules/nopt/bin/nopt.js
installing /nix/store/xzv8mkyw5bnqfb2gxwsr7kqmzlzcksyg-nodejs-11.0.0/lib/node_modules/npm/node_modules/node-gyp/README.md
installing /nix/store/xzv8mkyw5bnqfb2gxwsr7kqmzlzcksyg-nodejs-11.0.0/lib/node_modules/npm/node_modules/node-gyp/package.json
installing /nix/store/xzv8mkyw5bnqfb2gxwsr7kqmzlzcksyg-nodejs-11.0.0/lib/node_modules/npm/node_modules/node-gyp/LICENSE
installing /nix/store/xzv8mkyw5bnqfb2gxwsr7kqmzlzcksyg-nodejs-11.0.0/lib/node_modules/npm/node_modules/node-gyp/CONTRIBUTING.md
installing /nix/store/xzv8mkyw5bnqfb2gxwsr7kqmzlzcksyg-nodejs-11.0.0/lib/node_modules/npm/node_modules/node-gyp/CHANGELOG.md
installing /nix/store/xzv8mkyw5bnqfb2gxwsr7kqmzlzcksyg-nodejs-11.0.0/lib/node_modules/npm/node_modules/node-gyp/addon.gypi
installing /nix/store/xzv8mk
builder for '/nix/store/13ch5i0by1p758n8dl7vsmv7xrnwdhjf-nodejs-11.0.0.drv' failed with exit code 2
error: build of '/nix/store/13ch5i0by1p758n8dl7vsmv7xrnwdhjf-nodejs-11.0.0.drv' failed

GrahamcOfBorg · 2018-10-24T13:14:20Z

Failure on x86_64-linux (full log)

Attempted: nodejs-11_x

Partial log (click to expand)

installing /nix/store/0nsb1clih5k3d07xsb8sr4c315sybcnj-nodejs-11.0.0/lib/node_modules/npm/node_modules/lockfile/lockfile.js
installing /nix/store/0nsb1clih5k3d07xsb8sr4c315sybcnj-nodejs-11.0.0/lib/node_modules/npm/node_modules/lockfile/CHANGELOG.md
installing /nix/store/0nsb1clih5k3d07xsb8sr4c315sybcnj-nodejs-11.0.0/lib/node_modules/npm/node_modules/lockfile/.travis.yml
installing /nix/store/0nsb1clih5k3d07xsb8sr4c315sybcnj-nodejs-11.0.0/lib/node_modules/npm/node_modules/lockfile/README.md
installing /nix/store/0nsb1clih5k3d07xsb8sr4c315sybcnj-nodejs-11.0.0/lib/node_modules/npm/node_modules/lockfile/gen-changelog.sh
installing /nix/store/0nsb1clih5k3d07xsb8sr4c315sybcnj-nodejs-11.0.0/lib/node_modules/npm/node_modules/rimraf/bin.js
installing /nix/store/0nsb1clih5k3d07xsb8sr4c315sybcnj-nodejs-11.0.0/lib/node_modules/npm/node_modules/rimraf/LICENSE
installing /nix/store/0nsb1clih5k3d07xsb8sr4c315sybcnj-nodejs-
builder for '/nix/store/k1ww35ij6c9r0vxxrqpmid1lpmhpq3zm-nodejs-11.0.0.drv' failed with exit code 2
error: build of '/nix/store/k1ww35ij6c9r0vxxrqpmid1lpmhpq3zm-nodejs-11.0.0.drv' failed

GrahamcOfBorg · 2018-10-24T13:32:06Z

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: nodejs-11_x

Partial log (click to expand)

  clang++ -o /private/tmp/nix-build-nodejs-11.0.0.drv-0/node-v11.0.0/out/Release/obj.target/v8_base/deps/v8/src/regexp/regexp-macro-assembler.o ../deps/v8/src/regexp/regexp-macro-assembler.cc '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-D_DARWIN_USE_64_BIT_INODE=1' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.5"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT=1' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DENABLE_HANDLE_ZAPPING' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I/nix/store/qscisgacfgykr63pgmjp1s65rndma3wy-zlib-1.2.11-dev/include -I/nix/store/59c6bz08jxcyxyi962fhf56jzph3f333-libuv-1.23.1/include -I/nix/store/nd9q92a67zlavmwgf0230zxpsp9wgzyj-openssl-1.1.1-dev/include -I../deps/v8 -I../. -I/private/tmp/nix-build-nodejs-11.0.0.drv-0/node-v11.0.0/out/Release/obj/gen -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -O3 -gdwarf-2 -fstrict-aliasing -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++1y -stdlib=libc++ -fno-rtti -fno-exceptions -fno-strict-aliasing -MMD -MF /private/tmp/nix-build-nodejs-11.0.0.drv-0/node-v11.0.0/out/Release/.deps//private/tmp/nix-build-nodejs-11.0.0.drv-0/node-v11.0.0/out/Release/obj.target/v8_base/deps/v8/src/regexp/regexp-macro-assembler.o.d.raw   -c
  clang++ -o /private/tmp/nix-build-nodejs-11.0.0.drv-0/node-v11.0.0/out/Release/obj.target/v8_base/deps/v8/src/regexp/regexp-parser.o ../deps/v8/src/regexp/regexp-parser.cc '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-D_DARWIN_USE_64_BIT_INODE=1' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.5"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT=1' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DENABLE_HANDLE_ZAPPING' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I/nix/store/qscisgacfgykr63pgmjp1s65rndma3wy-zlib-1.2.11-dev/include -I/nix/store/59c6bz08jxcyxyi962fhf56jzph3f333-libuv-1.23.1/include -I/nix/store/nd9q92a67zlavmwgf0230zxpsp9wgzyj-openssl-1.1.1-dev/include -I../deps/v8 -I../. -I/private/tmp/nix-build-nodejs-11.0.0.drv-0/node-v11.0.0/out/Release/obj/gen -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -O3 -gdwarf-2 -fstrict-aliasing -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++1y -stdlib=libc++ -fno-rtti -fno-exceptions -fno-strict-aliasing -MMD -MF /private/tmp/nix-build-nodejs-11.0.0.drv-0/node-v11.0.0/out/Release/.deps//private/tmp/nix-build-nodejs-11.0.0.drv-0/node-v11.0.0/out/Release/obj.target/v8_base/deps/v8/src/regexp/regexp-parser.o.d.raw   -c
  clang++ -o /private/tmp/nix-build-nodejs-11.0.0.drv-0/node-v11.0.0/out/Release/obj.target/v8_base/deps/v8/src/regexp/regexp-stack.o ../deps/v8/src/regexp/regexp-stack.cc '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-D_DARWIN_USE_64_BIT_INODE=1' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.5"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT=1' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DENABLE_HANDLE_ZAPPING' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I/nix/store/qscisgacfgykr63pgmjp1s65rndma3wy-zlib-1.2.11-dev/include -I/nix/store/59c6bz08jxcyxyi962fhf56jzph3f333-libuv-1.23.1/include -I/nix/store/nd9q92a67zlavmwgf0230zxpsp9wgzyj-openssl-1.1.1-dev/include -I../deps/v8 -I../. -I/private/tmp/nix-build-nodejs-11.0.0.drv-0/node-v11.0.0/out/Release/obj/gen -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -O3 -gdwarf-2 -fstrict-aliasing -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++1y -stdlib=libc++ -fno-rtti -fno-exceptions -fno-strict-aliasing -MMD -MF /private/tmp/nix-build-nodejs-11.0.0.drv-0/node-v11.0.0/out/Release/.deps//private/tmp/nix-build-nodejs-11.0.0.drv-0/node-v11.0.0/out/Release/obj.target/v8_base/deps/v8/src/regexp/regexp-stack.o.d.raw   -c
  clang++ -o /private/tmp/nix-build-nodejs-11.0.0.drv-0/node-v11.0.0/out/Release/obj.target/v8_base/deps/v8/src/regexp/regexp-utils.o ../deps/v8/src/regexp/regexp-utils.cc '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-D_DARWIN_USE_64_BIT_INODE=1' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.5"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT=1' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DENABLE_HANDLE_ZAPPING' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I/nix/store/qscisgacfgykr63pgmjp1s65rndma3wy-zlib-1.2.11-dev/include -I/nix/store/59c6bz08jxcyxyi962fhf56jzph3f333-libuv-1.23.1/include -I/nix/store/nd9q92a67zlavmwgf0230zxpsp9wgzyj-openssl-1.1.1-dev/include -I../deps/v8 -I../. -I/private/tmp/nix-build-nodejs-11.0.0.drv-0/node-v11.0.0/out/Release/obj/gen -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -O3 -gdwarf-2 -fstrict-aliasing -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++1y -stdlib=libc++ -fno-rtti -fno-exceptions -fno-strict-aliasing -MMD -MF /private/tmp/nix-build-nodejs-11.0.0.drv-0/node-v11.0.0/out/Release/.deps//private/tmp/nix-build-nodejs-11.0.0.drv-0/node-v11.0.0/out/Release/obj.target/v8_base/deps/v8/src/regexp/regexp-utils.o.d.raw   -c
  clang++ -o /private/tmp/nix-build-nodejs-11.0.0.drv-0/node-v11.0.0/out/Release/obj.target/v8_base/deps/v8/src/register-configuration.o ../deps/v8/src/register-configuration.cc '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-D_DARWIN_USE_64_BIT_INODE=1' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.5"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT=1' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DENABLE_HANDLE_ZAPPING' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I/nix/store/qscisgacfgykr63pgmjp1s65rndma3wy-zlib-1.2.11-dev/include -I/nix/store/59c6bz08jxcyxyi962fhf56jzph3f333-libuv-1.23.1/include -I/nix/store/nd9q92a67zlavmwgf0230zxpsp9wgzyj-openssl-1.1.1-dev/include -I../deps/v8 -I../. -I/private/tmp/nix-build-nodejs-11.0.0.drv-0/node-v11.0.0/out/Release/obj/gen -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -O3 -gdwarf-2 -fstrict-aliasing -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++1y -stdlib=libc++ -fno-rtti -fno-exceptions -fno-strict-aliasing -MMD -MF /private/tmp/nix-build-nodejs-11.0.0.drv-0/node-v11.0.0/out/Release/.deps//private/tmp/nix-build-nodejs-11.0.0.drv-0/node-v11.0.0/out/Release/obj.target/v8_base/deps/v8/src/register-configuration.o.d.raw   -c
  clang++ -o /private/tmp/nix-build-nodejs-11.0.0.drv-0/node-v11.0.0/out/Release/obj.target/v8_base/deps/v8/src/reloc-info.o ../deps/v8/src/reloc-info.cc '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-D_DARWIN_USE_64_BIT_INODE=1' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.5"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT=1' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DENABLE_HANDLE_ZAPPING' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I/nix/store/qscisgacfgykr63pgmjp1s65rndma3wy-zlib-1.2.11-dev/include -I/nix/store/59c6bz08jxcyxyi962fhf56jzph3f333-libuv-1.23.1/include -I/nix/store/nd9q92a67zlavmwgf0230zxpsp9wgzyj-openssl-1.1.1-dev/include -I../deps/v8 -I../. -I/private/tmp/nix-build-nodejs-11.0.0.drv-0/node-v11.0.0/out/Release/obj/gen -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -O3 -gdwarf-2 -fstrict-aliasing -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++1y -stdlib=libc++ -fno-rtti -fno-exceptions -fno-strict-aliasing -MMD -MF /private/tmp/nix-build-nodejs-11.0.0.drv-0/node-v11.0.0/out/Release/.deps//private/tmp/nix-build-nodejs-11.0.0.drv-0/node-v11.0.0/out/Release/obj.target/v8_base/deps/v8/src/reloc-info.o.d.raw   -c
  clang++ -o /private/tmp/nix-build-nodejs-11.0.0.drv-0/node-v11.0.0/out/Release/obj.target/v8_base/deps/v8/src/runtime-profiler.o ../deps/v8/src/runtime-profiler.cc '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-D_DARWIN_USE_64_BIT_INODE=1' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.5"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT=1' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DENABLE_HANDLE_ZAPPING' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I/nix/store/qscisgacfgykr63pgmjp1s65rndma3wy-zlib-1.2.11-dev/include -I/nix/store/59c6bz08jxcyxyi962fhf56jzph3f333-libuv-1.23.1/include -I/nix/store/nd9q92a67zlavmwgf0230zxpsp9wgzyj-openssl-1.1.1-dev/include -I../deps/v8 -I../. -I/private/tmp/nix-build-nodejs-11.0.0.drv-0/node-v11.0.0/out/Release/obj/gen -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -O3 -gdwarf-2 -fstrict-aliasing -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++1y -stdlib=libc++ -fno-rtti -fno-exceptions -fno-strict-aliasing -MMD -MF /private/tmp/nix-build-nodejs-11.0.0.drv-0/node-v11.0.0/out/Release/.deps//private/tmp/nix-build-nodejs-11.0.0.drv-0/node-v11.0.0/out/Release/obj.target/v8_base/deps/v8/src/runtime-profiler.o.d.raw   -c
  clang++ -o /private/tmp/nix-build-nodejs-11.0.0.drv-0/node-v11.0.0/out/Release/obj.target/v8_base/deps/v8/src/runtime/runtime-array.o ../deps/v8/src/runtime/runtime-array.cc '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-D_DARWIN_USE_64_BIT_INODE=1' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.5"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT=1' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DENABLE_HANDLE_ZAPPING' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I/nix/store/qscisgacfgykr63pgmjp1s65rndma3wy-zlib-1.2.11-dev/include -I/nix/store/59c6bz08jxcyxyi962fhf56jzph3f333-libuv-1.23.1/include -I/nix/store/nd9q92a67zlavmwgf0230zxpsp9wgzyj-openssl-1.1.1-dev/include -I../deps/v8 -I../. -I/private/tmp/nix-build-nodejs-11.0.0.drv-0/node-v11.0.0/out/Release/obj/gen -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -O3 -gdwarf-2 -fstrict-aliasing -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++1y -stdlib=libc++ -fno-rtti -fno-exceptions -fno-strict-aliasing -MMD -MF /private/tmp/nix-build-nodejs-11.0.0.drv-0/node-v11.0.0/out/Release/.deps//private/tmp/nix-build-nodejs-11.0.0.drv-0/node-v11.0.0/out/Release/obj.target/v8_base/deps/v8/src/runtime/runtime-array.o.d.raw   -c
building of '/nix/store/ifhlprpk90vdkhv6gqkwwxlvy6brh97p-nodejs-11.0.0.drv' timed out after 1800 seconds
error: build of '/nix/store/ifhlprpk90vdkhv6gqkwwxlvy6brh97p-nodejs-11.0.0.drv' failed

bobvanderlinden · 2018-10-28T19:30:06Z

I tried to build this locally, but I ran into the same issue as borg. It failed with the following tail:

builder for '/nix/store/k1ww35ij6c9r0vxxrqpmid1lpmhpq3zm-nodejs-11.0.0.drv' failed with exit code 2; last 10 log lines:
  installing /nix/store/0nsb1clih5k3d07xsb8sr4c315sybcnj-nodejs-11.0.0/lib/node_modules/npm/doc/cli/npm-init.md
  installing /nix/store/0nsb1clih5k3d07xsb8sr4c315sybcnj-nodejs-11.0.0/lib/node_modules/npm/doc/cli/npm-install-test.md
  installing /nix/store/0nsb1clih5k3d07xsb8sr4c315sybcnj-nodejs-11.0.0/lib/node_modules/npm/doc/cli/npm-adduser.md
  installing /nix/store/0nsb1clih5k3d07xsb8sr4c315sybcnj-nodejs-11.0.0/lib/node_modules/npm/doc/cli/npm-dedupe.md
  installing /nix/store/0nsb1clih5k3d07xsb8sr4c315sybcnj-nodejs-11.0.0/lib/node_modules/npm/doc/cli/npm-hook.md
  installing /nix/store/0nsb1clih5k3d07xsb8sr4c315sybcnj-nodejs-11.0.0/lib/node_modules/npm/doc/cli/npm-publish.md
  installing /nix/store/0nsb1clih5k3d07xsb8sr4c315sybcnj-nodejs-11.0.0/lib/node_modules/npm/doc/cli/npm-update.md
  installing /nix/store/0nsb1clih5k3d07xsb8sr4c315sybcnj-nodejs-11.0.0/lib/node_modules/npm/doc/cli/npm-bin.md
  installing /nix/store/0nsb1clih5k3d07xsb8sr4c315sybcnj-nodejs-11.0.0/lib/node_modules/npm/doc/cli/npm-stop.md
  installing /nix/store/0nsb1clih5k3d07xsb8sr4c31
[0 built (1 failed), 0.0 MiB DL]
error: build of '/nix/store/k1ww35ij6c9r0vxxrqpmid1lpmhpq3zm-nodejs-11.0.0.drv' failed

It seemed to have just cut off the log somewhere at the end. Running the build takes quite a while, so I haven't figured out why this happens. Any ideas?

lo1tuma · 2018-10-29T10:38:12Z

I get the same error on nixos. It seems like something related to the build of npm fails because nodejs-slim-11_x works fine.

marsam · 2018-11-03T16:16:16Z

nodejs 11.1.0 released: https://nodejs.org/en/blog/release/v11.1.0/
FWIW I had no problems building nodejs-11x in Darwin or NixOS, @bobvanderlinden are you by any chance building it under an Emacs shell? I remember the same error happened to me there.

bobvanderlinden · 2018-11-04T13:07:22Z

@marsam No, just building on zsh. It also says error: build of '/nix/store/k1ww35ij6c9r0vxxrqpmid1lpmhpq3zm-nodejs-11.0.0.drv' failed, so it has to do with something in the build itself. It's just strange I cannot extract the actual log, neither by looking at the output nor by calling nix log -f . nodejs-11_x.

Ma27 · 2018-11-08T09:20:10Z

FYI the borg is currently experiencing similar issues on aarch64 in #49453, did all of you test the Linux build with sandbox enabled?

@bobvanderlinden it would be awesome if you could rerun (if the logs are missing) and post the log output into a github gist if possible :)

EDIT: I compiled nodejs v11 locally on my machine (x86-linux) and it works here as well...

bobvanderlinden · 2018-11-08T22:27:49Z

Yes, on NixOS with sandbox enabled. Rebuild it today and again the same result (yay determinism). Ran nix-build -A nodejs-11_x . > build.log 2>&1. See build.log here: https://gist.github.com/bobvanderlinden/009aa0361e160fb1368d5cae18557b26

Ma27 · 2018-11-11T22:40:43Z

So... as the build seems to have aborted in the middle of the install phase (so did borg, but earlier) without an (obvious) failure, I can currently think of two possibilities:

there's an issue with nix itself (I don't know too much about the internals of it, so I'm absolutely not sure here, is there something suspicious in the logs of your nix-daemon e.g.?)
we ran into a build timeout and the build has been terminated (I mostly build stuff on a server which runs mostly trivial stuff on it and is therefore (more or less) idle). According to commits like 83fd978 it should be possible to specify an elevated build timeout. Does anybody who could reproduce the issue during the install phase try if this helps?

lo1tuma · 2018-11-12T15:49:58Z

@selaux can you give this a try 👆?

bobvanderlinden · 2018-11-12T18:55:40Z

Another possible cause is lack of memory. I wasn't tracking the memory, but I can imagine Nix or the system is running out of its max memory (for the sandbox?). I'm not sure if there are limitations in that regard.

selaux · 2018-11-13T11:51:26Z

Yes, on NixOS with sandbox enabled. Rebuild it today and again the same result (yay determinism).

I made a different experience. I built this PR multiple times on different machines and at one point the build succeeded on a machine where it previously failed. But this happened only a single time out of about 10 builds.

selaux · 2018-11-13T14:20:13Z

Increasing timeouts does not work for me either. Here is a build log of a failing build using nix-build --timeout 7200 -A nodejs-11_x .: https://gist.github.com/selaux/aa517b4798fa27acb2b915dc22b9a72a

Ma27 · 2018-11-13T14:58:46Z

@selaux thanks a lot for looking into this!

Your build log is more or less the same as the one of @bobvanderlinden, it suddenly aborts during install phase. When you run journalctl -u nix-daemon.service, is there anything looking suspicious?

selaux · 2018-11-13T15:17:31Z

No, nothing. Just:

Nov 13 12:54:14 nixos nix-daemon[10691]: accepted connection from pid 31076, user xxxxx

Can I somehow increase verbosity for the nix-daemon?

Ma27 · 2018-11-13T21:32:25Z

Unfortunately I didn't find anything useful in the man page and the nix module, but I might be missing something.

I'll try a local build tonight (maybe this makes a difference) and posted this PR into #nixos-dev on freenode, maybe someone with more knowledge about Nix internals has an idea

Ma27 · 2018-11-14T01:33:37Z

Short update from my side: I just tried to build nodejs 11 locally (while doing some additional work, so IDE and stuff eating resources as well) and now it breaks the build which confirms the assumption that this is somehow related to limited resources on the building machine.

I'm not exactly sure how to proceed here, I added this to my TODO list and I'm planning to have a deeper look at this next weekend. (If anybody wants to take over, feel free :P)

Ma27 · 2018-11-16T22:16:54Z

I managed to compile this using meta.timeout = 1800; in pkgs/development/web/nodejs/nodejs.nix locally (previously I had a sudden abort during install phase as well).

The nix-build manual says the timeout = 0 means no timeout. Would it be possible to test this folks? I'd recommend to set a high timeout to allow getting nodejs built on Hydra.

bobvanderlinden · 2018-11-17T11:57:17Z

I ran it again with:

diff --git a/pkgs/development/web/nodejs/nodejs.nix b/pkgs/development/web/nodejs/nodejs.nix
index ea764ef22e6..e34711226e1 100644
--- a/pkgs/development/web/nodejs/nodejs.nix
+++ b/pkgs/development/web/nodejs/nodejs.nix
@@ -107,6 +107,7 @@ in
     };

     meta = {
+      timeout = 0;
       description = "Event-driven I/O framework for the V8 JavaScript engine";
       homepage = https://nodejs.org;
       license = licenses.mit;

But got the same behaviour:

installing /nix/store/0nsb1clih5k3d07xsb8sr4c315sybcnj-nodejs-11.0.0/lib/node_modules/npm/doc/cli/npm-update.md
installing /nix/store/0nsb1clih5k3d07xsb8sr4c315sybcnj-nodejs-11.0.0/lib/node_modules/npm/doc/cli/npm-bin.md
installing /nix/store/0nsb1clih5k3d07xsb8sr4c315sybcnj-nodejs-11.0.0/lib/node_modules/npm/doc/cli/npm-stop.md
installing /nix/store/0nsb1clih5k3d07xsb8sr4c31
builder for '/nix/store/k1ww35ij6c9r0vxxrqpmid1lpmhpq3zm-nodejs-11.0.0.drv' failed with exit code 2
error: build of '/nix/store/k1ww35ij6c9r0vxxrqpmid1lpmhpq3zm-nodejs-11.0.0.drv' failed

I also tried setting it to 1, but that didn't timeout the build! I think the timeout option in meta is not a valid option.

Also note that I tried:

nix-build --timeout 1 -A nodejs-11_x .

But that outputs the following:

these derivations will be built:
  /nix/store/k1ww35ij6c9r0vxxrqpmid1lpmhpq3zm-nodejs-11.0.0.drv
building '/nix/store/k1ww35ij6c9r0vxxrqpmid1lpmhpq3zm-nodejs-11.0.0.drv'...
unpacking sources
unpacking source archive /nix/store/8z1ffbbh6l6a9rip5dl988h1rqdwanjp-node-v11.0.0.tar.xz
building of '/nix/store/k1ww35ij6c9r0vxxrqpmid1lpmhpq3zm-nodejs-11.0.0.drv' timed out after 1 seconds
error: build of '/nix/store/k1ww35ij6c9r0vxxrqpmid1lpmhpq3zm-nodejs-11.0.0.drv' failed

So, the timeout option of nix-build does output that the build did timeout after X seconds. That does not happen for the failing build, so I'm still unsure whether timeouts are related.

Ma27 · 2018-11-19T21:35:45Z

thanks a lot for your report! Admittedly I'm slightly confused, but as this issue isn't 100% reproducible either, I could've had "bad luck" while building locally :)

Please give me some more time until tomorrow, I'll see when meta.timeout actually works (I've seen this in some other derivations though, but this may be for Hydra only).

Ma27 · 2018-11-25T15:56:45Z

@bobvanderlinden I had another look at this last night and I can confirm that my previous report was premature and unfortunately a false-positive, I'm sorry for that. After having a look at the sources it seems as this meta option is only used by Hydra to determine build timeouts in jobsets.

It's most likely that my local build from the 16th November passed due to a low load on my machine. Yesterday I partly got passing builds locally, but I managed to reliably reproduce the build failures by running nix-shell -p stress --run "stress -c 2" (I have an Intel Core i5-7200U processor and 8GB RAM).

In case this is helpful for anybody, I ran the build with strace -f yesterday. From what I can tell it simply read the output of the installer script and redirected it to stderr. It's likely that some heuristics internally abort the build in case of builds on machines with elevated resource consumption, but I couldn't find anything helpful in the strace logs.

I'm truly sorry, but I'm afraid that this issue exceeds my knowledge about how Nix works internally. For now I'm pinging @cillianderoiste, @gilligan and @cko as they're listed as NodeJS maintainers. Do you folks have an idea what might go wrong here?

Of course I'll read the notifications about this thread and try to help, but I could use some support of people with more experience about Nix and/or NodeJS internals :)

gilligan · 2018-11-25T16:01:59Z

All of this sounds rather weird indeed. I’ll try to have a look asap and will ping some other folks if I don’t find anything either..

marsam · 2018-11-25T17:06:16Z

wild guess, can you try increasing the size of the tmp folder?

marsam · 2018-12-19T02:09:04Z

nodejs v11.5.0 released https://nodejs.org/en/blog/release/v11.5.0/

Can we get this merged? I can build it on Darwin and NixOS

Ma27 · 2018-12-20T16:34:32Z

@lo1tuma @bobvanderlinden did anybody of you try this?

selaux · 2018-12-21T09:20:45Z

@Ma27 Tried again after rebasing on master, same issue still persists. My /tmp folder size is 12 Gb, that should be sufficient to build nodejs right? @marsam What size should it be increased to?

Regarding nodejs 11.5.0 they seem to have introduced a new dependency llhttp that should be a replacement for http-parser in the long term. But for 11.5.0 both parsers seem to be required. See nodejs/node#24730. So this one requires a little more effort.

selaux · 2018-12-21T10:20:04Z

I updated the PR for 11.5.0 (though I cannot update the title).

I invested a little time and it seems like NodeJS 11.5.0 builds just fine for me when disabling the shared http-parser, as is already done on darwin. I needed to do this because this flag now stands for --use-shared-http-parser-and-llhttp, so we would need to provide both as shared libraries and I don't know how to build and provide llhttp: https://github.com/nodejs/llhttp. We could investigate some more and create a patch to change the behavior of the flag to only include http-parser, but I dont know if it is worth the effort. I checked the Arch PKGBUILD and they seem to go down the same route: https://git.archlinux.org/svntogit/community.git/commit/trunk?h=packages/nodejs&id=92bc2704be32fb47b8466045e9bcb1b8596c4424

Please test the current version. I still don't understand why the 11.0.0 variant of the PR failed though. Maybe too many (open) files?

Ma27 · 2018-12-21T11:37:07Z

Updated the PR's title.

Unfortunately I don't know nodejs internals too much, so I'm not sure if what went wrong during the build process.

selaux · 2018-12-21T12:23:56Z

@Ma27 Can you trigger @GrahamcOfBorg so we can see if it builds everywhere?

Ma27 · 2018-12-21T12:25:50Z

@GrahamcOfBorg build nodejs-11_x nodejs-slim-11_x

gilligan · 2018-12-29T19:43:31Z

LGTM - someone with merge permissions please hit the green button ;-)

infinisil · 2018-12-29T21:05:00Z

Builds fine for me on NixOS and Darwin, let's merge this :)

Ma27 · 2018-12-29T21:18:08Z

seen the notification just now, thanks to everyone who helped getting this working!

GrahamcOfBorg added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 23, 2018

lo1tuma mentioned this pull request Oct 27, 2018

nodejs-slim-10_x: 10.12.0 -> 11.0.0 #49207

Closed

lo1tuma mentioned this pull request Nov 8, 2018

Update nodejs-10_x to 10.13.0 #49453

Closed

9 tasks

Ma27 mentioned this pull request Nov 10, 2018

Update nodejs v10 to 10.13.0 and add nodejs v11 #49508

Closed

Ma27 mentioned this pull request Nov 24, 2018

nodejs-slim-10_x: 10.12.0 -> 11.2.0 #50677

Closed

selaux force-pushed the nodejs-11 branch from 43e7bfa to 985c6c4 Compare December 21, 2018 10:08

nodejs-11_x: init at 11.5.0

e6a86e6

selaux force-pushed the nodejs-11 branch from 985c6c4 to e6a86e6 Compare December 21, 2018 10:24

Ma27 changed the title ~~nodejs: init at 11.0.0~~ nodejs: init at 11.5.0 Dec 21, 2018

gilligan approved these changes Dec 29, 2018

View reviewed changes

infinisil merged commit ebdfafd into NixOS:master Dec 29, 2018

nodejs: init at 11.5.0 #48911

nodejs: init at 11.5.0 #48911

Conversation

lo1tuma commented Oct 23, 2018

Motivation for this change

Things done

adisbladis commented Oct 24, 2018

GrahamcOfBorg commented Oct 24, 2018

GrahamcOfBorg commented Oct 24, 2018

GrahamcOfBorg commented Oct 24, 2018

bobvanderlinden commented Oct 28, 2018

lo1tuma commented Oct 29, 2018

marsam commented Nov 3, 2018

bobvanderlinden commented Nov 4, 2018

Ma27 commented Nov 8, 2018 • edited Loading

bobvanderlinden commented Nov 8, 2018

Ma27 commented Nov 11, 2018

lo1tuma commented Nov 12, 2018 • edited Loading

bobvanderlinden commented Nov 12, 2018

selaux commented Nov 13, 2018

selaux commented Nov 13, 2018

Ma27 commented Nov 13, 2018

selaux commented Nov 13, 2018

Ma27 commented Nov 13, 2018

Ma27 commented Nov 14, 2018

Ma27 commented Nov 16, 2018

bobvanderlinden commented Nov 17, 2018

Ma27 commented Nov 19, 2018

Ma27 commented Nov 25, 2018 • edited Loading

gilligan commented Nov 25, 2018

marsam commented Nov 25, 2018

marsam commented Dec 19, 2018

Ma27 commented Dec 20, 2018

selaux commented Dec 21, 2018

selaux commented Dec 21, 2018

Ma27 commented Dec 21, 2018

selaux commented Dec 21, 2018

Ma27 commented Dec 21, 2018

gilligan commented Dec 29, 2018

infinisil commented Dec 29, 2018

Ma27 commented Dec 29, 2018

Ma27 commented Nov 8, 2018 •

edited

Loading

lo1tuma commented Nov 12, 2018 •

edited

Loading

Ma27 commented Nov 25, 2018 •

edited

Loading