Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tcl: link with libgcc_s #54526

Closed
wants to merge 1 commit into from
Closed

tcl: link with libgcc_s #54526

wants to merge 1 commit into from

Conversation

pbogdan
Copy link
Member

@pbogdan pbogdan commented Jan 24, 2019

Motivation for this change

I'm not confident this is just the right condition to link to it only on platforms / environments where this is needed.

/cc @matthewbauer @dtzWill

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthewbauer
Copy link
Member

I guess it depends on how many of these kind of fixes are needed. If there are lots of libgcc_s that now need to be added, we probably need to figure out how to get things to pick up the "default" one.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 501+ labels Jan 24, 2019
@pbogdan pbogdan closed this Jan 24, 2019
@pbogdan pbogdan deleted the tcl-libgcc-s branch January 24, 2019 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 501+
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants