Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "rustc: 1.31.0 -> 1.32.0" #55379

Merged
merged 1 commit into from
Feb 7, 2019
Merged

Revert "rustc: 1.31.0 -> 1.32.0" #55379

merged 1 commit into from
Feb 7, 2019

Conversation

timokau
Copy link
Member

@timokau timokau commented Feb 7, 2019

Motivation for this change

This reverts commit 56dba36. It breaks some packages and a version of the update with fixes applied (#54323) is already in staging.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau timokau requested review from LnL7 and Mic92 as code owners February 7, 2019 10:26
timokau referenced this pull request Feb 7, 2019
@edolstra
rustc: 1.31.0 -> 1.32.0
56dba36
@timokau timokau merged commit 882131e into NixOS:master Feb 7, 2019
@timokau timokau deleted the rustc-revert branch February 7, 2019 11:49
@timokau
Copy link
Member Author

timokau commented Feb 8, 2019

Apparently the rustfmt update to 1.0.1 depended on the rustc update. I'll revert that too and cherry-pick it to staging instead.

timokau added a commit to timokau/nixpkgs that referenced this pull request Feb 8, 2019
@timokau
Revert "rustfmt: 1.0.0 -> 1.0.1"
5f5c71b 
This reverts commit 7fff567. It depends
on the rustc update I reverted in NixOS#55379. It should be re-introduced
after that rustc update has gone through staging.
@timokau timokau mentioned this pull request Feb 8, 2019
Merged
10 tasks
@timokau
Copy link
Member Author

timokau commented Feb 8, 2019

#55437, #55438

timokau added a commit that referenced this pull request Feb 8, 2019
@timokau
Revert "rustfmt: 1.0.0 -> 1.0.1" (#55437)
295acfc 
This reverts commit 7fff567. It depends
on the rustc update I reverted in #55379. It should be re-introduced
after that rustc update has gone through staging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 Awaiting requested review from LnL7

@Mic92 Mic92 Awaiting requested review from Mic92

@globin globin Awaiting requested review from globin

@wizeman wizeman Awaiting requested review from wizeman

@cstrahan cstrahan Awaiting requested review from cstrahan

@madjar madjar Awaiting requested review from madjar

Assignees
No one assigned
Labels
6.topic: rust 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timokau @GrahamcOfBorg