Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch patchelf for golang support #57618

Closed
wants to merge 1 commit into from
Closed

Conversation

booxter
Copy link
Contributor

@booxter booxter commented Mar 14, 2019

This patch fixes patchelf for golang binaries.

@booxter booxter changed the title Patch patchself for golang support Patch patchelf for golang support Mar 14, 2019
@GrahamcOfBorg GrahamcOfBorg added the 10.rebuild-linux-stdenv This PR causes stdenv to rebuild label Mar 14, 2019
@GrahamcOfBorg GrahamcOfBorg requested a review from edolstra March 14, 2019 02:18
@booxter
Copy link
Contributor Author

booxter commented Mar 14, 2019

I now realize that perhaps this PR, due to it triggering massive rebuild, is a better candidate for staging branch. Is it correct? Should I abandon it here and instead propose for staging?

@veprbl
Copy link
Member

veprbl commented Mar 14, 2019

@booxter Yes, that's right.

@booxter
Copy link
Contributor Author

booxter commented Mar 14, 2019

@veprbl gotcha, posted it here for staging: #57656

@booxter booxter closed this Mar 14, 2019
@booxter booxter deleted the patchelf-go branch March 29, 2019 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants