Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodejs: cross compile runtime for ARM #57816

Merged
merged 1 commit into from
Nov 3, 2019
Merged

nodejs: cross compile runtime for ARM #57816

merged 1 commit into from
Nov 3, 2019

Conversation

illegalprime
Copy link
Member

Motivation for this change

add configure flags to cross compile the node.js runtime to ARM

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

illegalprime
illegalprime commented Mar 17, 2019
View reviewed changes
pkgs/development/web/nodejs/nodejs.nix
@@ -94,7 +112,7 @@ in
postInstall = ''
PATH=$out/bin:$PATH patchShebangs $out

${optionalString enableNpm ''
${optionalString (enableNpm && stdenv.hostPlatform == stdenv.buildPlatform) ''
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe the build-time npm can be used to create bash completions for cross compiling

@veprbl veprbl added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Apr 11, 2019
@ofborg ofborg bot requested a review from gilligan September 16, 2019 10:48
@FRidh FRidh merged commit 5b96d9c into NixOS:master Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer approved these changes

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

@gilligan gilligan Awaiting requested review from gilligan

Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@illegalprime @matthewbauer @veprbl @FRidh @GrahamcOfBorg