Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: fix rust build-support debug build type #63762

Closed
wants to merge 1 commit into from

Conversation

AtkinsChang
Copy link
Contributor

@AtkinsChang AtkinsChang commented Jun 25, 2019

Motivation for this change

buildType introduced in #56540 is not working because there is no --debug options for cargo.

According to cargo:

Compilation can be configured via the use of profiles which are configured in
the manifest. The default profile for this command is `dev`, but passing
the --release flag will use the `release` profile instead.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@AtkinsChang AtkinsChang changed the title Fix rust build-support rust: fix rust build-support Jun 26, 2019
@AtkinsChang AtkinsChang changed the title rust: fix rust build-support rust: fix rust build-support debug build type Jun 26, 2019
@AtkinsChang
Copy link
Contributor Author

@illegalprime could you help to review this?

@xrelkd xrelkd mentioned this pull request Jul 8, 2019
10 tasks
@FRidh FRidh requested a review from Ericson2314 July 17, 2019 08:49
@AtkinsChang
Copy link
Contributor Author

duplicated
#63666

@AtkinsChang AtkinsChang deleted the fix_rust_build_support branch August 8, 2021 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant