-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] environment.etc: loaOf -> attrsOf #67458
Conversation
ca312fe
to
295ed7e
Compare
295ed7e
to
bf15467
Compare
Checkout PR #63103: I'm also trying to deprecate loaOf and remove its use in nixpkgs. |
Ah I did not know about this PR. Let me know if anything here would help with it and I could try to move it over? |
It just needs a lot of testing but I don't have the time/resources to test all the software I touched.
|
I agree though even |
this feels like the sort of thing that should be an rfc? |
I'll leave this up for the moment in case it is useful for checking / comparing |
I personally don't agree with that at all. You are trying to fix a bug. This just needs adequate awareness and testing, IMO. |
Motivation for this change
Having
environment.etc
set using a list makes it very hard to override withmkForce
see: https://logs.nix.samueldr.com/nixos/2019-08-25#2523375;
Things done
Changed the type of
environment.etc
toattrsOf
and changed every instance of it being set with a list in nixossandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @aanderse @cleverca22
I'm sure there are a lot of mistakes in what I've done, especially with
mapAttrs'
. Is there any way to go about checking this automatically?Also I expect my commit names aren't very good or maybe they should be squashed, I'm happy to rebase if someone suggests something better