treewide: replace make/build/configure/patchFlags with nix lists

[merijnb]

Motivation for this change

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

Notify maintainers

cc @globin Contribution from Nixcon Hackathon.

This commit wasn't even compiled, so will likely have syntax errors. It was made by running a crude sequence of sed steps, after discussing with @globin at Nixcon. These were the sed steps for example for one set of flags:

rg -l 'configureFlags = "' | xargs -n 1 sed -i 's/Flags = "\([^ ]*\) \(.*\)"/Flags = "\1" "\2"/'
rg -l 'configureFlags = "' | xargs -n 1 sed -i 's/Flags = "\([^ ]*\)" "\([^ ]*\) \(.*\)"/Flags = "\1" "\2" "\3"/' 
rg -l 'configureFlags = "' | xargs -n 1 sed -i 's/Flags = "\([^ ]*\)" "\([^ ]*\)" "\([^ ]*\) \(.*\)"/Flags = "\1" "\2" "\3" "\4"/' 
rg -l 'configureFlags = "[^ ]*"' | xargs -n 1 sed -i 's/Flags = "\(.*\)"/Flags = \[ "\1" \]/'

This gets quite a few constructs wrong, I've fixed the ones I've noticed wrong. It will get legitimate spaces inside the strings wrong, or if there is an if else on the same line.

I'll make a small python program that will work better, so other flags can be changed by @globin when he comes across more.

[jonringer]

is that the right base branch?

[FRidh]

Should we use placeholder?

[globin]

fine for now

[merijnb]

is that the right base branch?

This is debatable. It is intentional, to help the structured-attrs branch to move forward and not be hung up on packages breaking for these small issues. Leaving this in that branch (which is not intended to hit until after 20.03) will make for a lot of churn to keep it in sync with master, so cherry picking this forward earlier seems like a good idea.

[FRidh]

If I understand correctly it is a dependency for structured attributes. It is however a good change to get in anyway and is thus best merged as soon as possible.

[globin]

yeah this is just help] for my work on #72074, thanks @merijnb!