Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Switch to gcc 5 #7807

Closed
wants to merge 9 commits into from
Closed

[WIP] Switch to gcc 5 #7807

wants to merge 9 commits into from

Conversation

shlevy
Copy link
Member

@shlevy shlevy commented May 11, 2015

No description provided.

@edolstra
Copy link
Member

I don't think we should switch to GCC 5 at this point. It seems way too early. I mean, it was released two weeks ago...

@shlevy
Copy link
Member Author

shlevy commented May 11, 2015

Any reason I can't start testing?

@shlevy
Copy link
Member Author

shlevy commented May 11, 2015

@edolstra
Copy link
Member

I'd rather spend hydra.nixos.org resources testing 4.9. Unfortunately it's pretty overloaded lately :-(

@shlevy
Copy link
Member Author

shlevy commented May 11, 2015

That seems strange to me. It's one thing if we find seriously insurmountable problems with gcc 5, but if we're taking the hit of a gcc upgrade anyway why not get the ABI issues over with and get the benefit of all the new features and bug fixes?

@edolstra
Copy link
Member

With GCC 5 you also get the "benefit" of all the new bugs :-)

GCC 4.9 has been out for a year, so it's likely to be more stable than 5.1, and most package breakage will have been fixed in the meantime. It also doesn't involve an ABI change so it should be a fairly uncomplicated update.

But I just noticed you're using release-small.nix, so I have no problem with building it on Hydra. (Main problem lately is disk space, but a small release shouldn't eat up much...)

@shlevy
Copy link
Member Author

shlevy commented May 11, 2015

OK, cool. Any way the community can contribute to more disk space?

@vcunat
Copy link
Member

vcunat commented May 11, 2015

The C++ ABI change shouldn't be a problem, IMHO. As explained, the old ABI is kept with the old linking names, and a new one is added. You choose by #defining a macro, so we could even make it use the old ABI by default, but I don't see a reason for that.

In the docs on changes for both 4.9 and 5, I don't see anything likely to cause larger problems, but OTOH undiscovered-bug potential seems hard to predict.

@edolstra
Copy link
Member

Libstdc++ may be dual-ABI, but that doesn't apply to other packages. So if you have a package that requires GCC 4, you need to build a separate copy of every C++ dependency (like Boost) with the old ABI.

@shlevy
Copy link
Member Author

shlevy commented May 11, 2015

Yes, we will either need to drop support for old gcc versions or force th old ABI everywhere

@vcunat
Copy link
Member

vcunat commented May 11, 2015

ATM I can only see three packages referring gcc older than our current (4.8), so the possibility of many packages needing dual build seems very unlikely to me.

@shlevy shlevy force-pushed the gcc-5 branch 3 times, most recently from b9c1b5b to 7ebf9ed Compare May 12, 2015 21:10
@shlevy shlevy force-pushed the gcc-5 branch 4 times, most recently from f5a0c1c to 2944f33 Compare May 20, 2015 20:38
@vcunat vcunat added this to the 15.10 milestone Jul 9, 2015
@vcunat vcunat added the 1.severity: mass-rebuild This PR causes a large number of packages to rebuild label Oct 12, 2015
@nbp nbp added the 2.status: work-in-progress This PR isn't done label Nov 20, 2015
@edolstra
Copy link
Member

GCC 5 is now in staging (dd53c65).

@edolstra edolstra closed this Mar 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: mass-rebuild This PR causes a large number of packages to rebuild 2.status: work-in-progress This PR isn't done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants