Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/ibus: add ibus portal if portals are enabled #83625

Merged
merged 1 commit into from
Apr 1, 2020
Merged

nixos/ibus: add ibus portal if portals are enabled #83625

merged 1 commit into from
Apr 1, 2020

Conversation

worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Mar 28, 2020 •
edited
Loading

Motivation for this change

We should add portals like we do in other places, but conditionally.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace mentioned this pull request Mar 28, 2020
Closed
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 28, 2020
@symphorien
Copy link
Member

This does not change anything to #75120: without IBUS_USE_PORTAL there is a delay, with it there is no delay. Tested on XFCE+i3.

@worldofpeace
Copy link
Contributor Author

Yeah @jtojnar confirmed this. We should add the portal, though.

@worldofpeace worldofpeace merged commit 8c093bd into NixOS:master Apr 1, 2020
@worldofpeace worldofpeace deleted the ibus-portal branch April 1, 2020 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@worldofpeace @symphorien