lib: add makeOverridableWithName + build*Package overrides #87394
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Improve the extensibility of language specific package builders.
Some of current
build*Package
functions support more overriding capabilities than others:buildPythonPackage
supports overriding packages viamakeOverridable
andoverridePythonAttrs
buildLuarocksPackage
andbuildRubyGem
support overriding packages viamakeOverridable
buildRustPackage
andbuildPerlPackage
supports no overridingIn theory
makeOverridable
should be enough to make a builder function overridable, but in practice this doesn't always work, because anothercallPackage
might shadow the wantedoverride
function.buildPythonPackage
works around this by providing aoverridePythonAttrs
function which is essentially aoverride
with a custom name.Things done
This PR adds a
lib.makeOverridableWithName
function, which is justlib.makeOverridable
with a additional namedoverride
function.It also adjusts the
build*Package
functions that I'm familiar with to use the new helper.sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)