-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/logrotate: Add options for basic paths #87702
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, just some minor points I thought of which you're free to take or leave 👍. Out of curiosity what motivated you to go with an attribute set over a list for options?
Formatting; In order to use the path as a key in the options. I could also use |
You're good with giving up control over sort order? I can't recall if that would be important at all... 🤔 |
f5a452b
to
9b93cd7
Compare
I changed |
See #63103 |
Okay. Does the order matter? I can make it a list or attribute set. |
I found this on the logrotate man page so I'll change it to a list of submodules:
|
22dccca
to
8865e4b
Compare
I updated the description to say list of attribute sets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good 👍 We could actually start using this internally given the ability to override 🎉
I'll test this out in the next few days. Thanks!
Co-authored-by: Ryan Mulligan <ryan@ryantm.com>
@aanderse, we are still interested in your feedback. jslight90 and I've been using something like this for a while though, so I went ahead and merged it. |
@ryantm sorry I got tied up and this sorta dropped off my radar... Thanks! Looking forward to using it 🎉 |
Motivation for this change
Add basic options for rotating paths.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)