Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] fix node-red build issue #89205 #96484

Closed
wants to merge 0 commits into from
Closed

[20.03] fix node-red build issue #89205 #96484

wants to merge 0 commits into from

Conversation

arapov
Copy link
Contributor

@arapov arapov commented Aug 27, 2020

Motivation for this change

This resolves node-red build issue #89205.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kloenk
Copy link
Member

kloenk commented Aug 27, 2020

Please add [20.03] so its clear its a backport.

@arapov arapov changed the title fix node-red build issue #89205 [20.03] fix node-red build issue #89205 Aug 27, 2020
@worldofpeace worldofpeace changed the base branch from nixos-20.03 to release-20.03 September 8, 2020 23:30
@worldofpeace
Copy link
Contributor

Hi @arapov, thanks for contributing. Could you re-do your cherry-pick with git cherry-pick -x $ref? That adds a little comment to the commit message showing what commit it came from.

@worldofpeace
Copy link
Contributor

also reviewed the original #96485 (review)

@arapov arapov closed this Sep 9, 2020
@arapov
Copy link
Contributor Author

arapov commented Sep 9, 2020

@worldofpeace #97506

@arapov arapov deleted the nixos-20.03 branch September 9, 2020 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arapov @kloenk @worldofpeace @Janik-Haag