report build failures as failures

NixOS · Feb 1, 2024 · 909000d · 909000d
1 parent 7db074d
commit 909000d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/ofborg/src/message/buildresult.rs b/ofborg/src/message/buildresult.rs
@@ -30,10 +30,10 @@ impl From<BuildStatus> for Conclusion {
         match status {
             BuildStatus::Skipped => Conclusion::Skipped,
             BuildStatus::Success => Conclusion::Success,
-            BuildStatus::Failure => Conclusion::Neutral,
+            BuildStatus::Failure => Conclusion::Failure,
             BuildStatus::HashMismatch => Conclusion::Failure,
             BuildStatus::TimedOut => Conclusion::Neutral,
-            BuildStatus::UnexpectedError { .. } => Conclusion::Neutral,
+            BuildStatus::UnexpectedError { .. } => Conclusion::Failure,
         }
     }
 }

diff --git a/ofborg/src/tasks/githubcommentposter.rs b/ofborg/src/tasks/githubcommentposter.rs
@@ -384,7 +384,7 @@ patching script interpreter paths in /nix/store/pcja75y9isdvgz5i00pkrpif9rxzxc29
                 started_at: None,
                 completed_at: Some("2023-04-20T13:37:42Z".to_string()),
                 status: Some(CheckRunState::Completed),
-                conclusion: Some(Conclusion::Neutral),
+                conclusion: Some(Conclusion::Failure),
                 details_url: Some(
                     "https://logs.ofborg.org/?key=nixos/nixpkgs.2345&attempt_id=neatattemptid"
                         .to_string()
@@ -621,7 +621,7 @@ patching script interpreter paths in /nix/store/pcja75y9isdvgz5i00pkrpif9rxzxc29
                 started_at: None,
                 completed_at: Some("2023-04-20T13:37:42Z".to_string()),
                 status: Some(CheckRunState::Completed),
-                conclusion: Some(Conclusion::Neutral),
+                conclusion: Some(Conclusion::Failure),
                 details_url: Some(
                     "https://logs.ofborg.org/?key=nixos/nixpkgs.2345&attempt_id=neatattemptid"
                         .to_string()