eval: Only support Nixpkgs #649
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cole-h
reviewed
Aug 18, 2023
| @@ -290,7 +290,13 @@ impl<'a, E: stats::SysEvents + 'static> OneEval<'a, E> { | |||
| } | |||
| }; | |||
|
|
|||
| let mut evaluation_strategy: Box<dyn eval::EvaluationStrategy> = if job.is_nixpkgs() { | |||
| if !job.is_nixpkgs() { | |||
| error!( | |||
There was a problem hiding this comment.
This will only log an error, not cause the function to exit with an error; you'll need to return Err(.........); after this.
There was a problem hiding this comment.
I tried this, but I'm not sure where the error should be handled. Ideally already at ofborg startup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ofborg seems only used on Nixpkgs with no intention of using it for other repos, so let's not have code to support that unless needed.