-
-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
patchelf.cc: handle DT_MIPS_XHASH and .MIPS.xhash #380
Conversation
This fixes #368 on my testing setup. Will reverify once I confirm that it fixes the QEMU-VM test case in that PR, but I'm pretty darn sure it will work. |
This commit adds two symbols (SHT_MIPS_XHASH and DT_MIPS_XHASH) found in glibc, and updates the value of DT_MIPS_NUM. These changes were made to glibc in 23c1c256ae7b0f010d0fcaff60682b620887b164 on 29-Aug-2019.
glibc changed their ABI in commit 23c1c256ae7b0f010d0fcaff60682b620887b164 on 2019-Aug-29, by changing the structure of the .gnu.hash data on MIPS and moving it to a different section. We need to adapt to this change by glibc. Closes #368
This bug has been sufficiently frustrating to track down that I want to make sure I've completely documented how to both (a) reproduce it and (b) verify that it is fixed. I'm currently running the commands below (which require quite a lot of rebuilding); as soon as they finish sometime tonight I will undraftify this PR. Thank you for your patience. Instructions for verifying this bug, and the fact that it is indeed fixed (based on #368):
Once the VM boots, type Then, shut down the VM, cherry-pick NixOS/nixpkgs@12618e7 into your |
Yep, it works, and the steps above reproduce the problem and verify the fix. |
I have not reproduced your issue due to limited resources but the fix makes sense. |
Ping... |
glibc changed their ABI in commit 23c1c256ae7b0f010d0fcaff60682b620887b164 on 2019-Aug-29, by changing the structure of the
.gnu.hash
data on MIPS and moving it to a different section. We need to adapt to this change by glibc.Closes #368