Use the largest segment alignment for libraries requiring non-standard alignments #474 #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brenoguim
changed the title
brenoguim
force-pushed
the
breno.474
branch
3 times, most recently
from
a344645
to
637f96b
Compare
brenoguim
changed the title
brenoguim
changed the title
brenoguim
changed the title
Mic92
reviewed
Mar 8, 2023
Co-authored-by: Jörg Thalheim <Mic92@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out libraries can have a larger than usual alignment on their LOAD segments. Patchelf should try to play along and use the largest alignment if its going to add a new LOAD segment