chore(CI): run tests on CentOS 7 #494
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix test build issue: ``` gcc -pie -g -O2 -Wl,--disable-new-dtags -Wl,-rpath-link=. -L. -o many-syms-main many_syms_main-many-syms-main.o -lmany-syms /opt/rh/devtoolset-10/root/usr/libexec/gcc/s390x-redhat-linux/10/ld: many_syms_main-many-syms-main.o: `f1' non-PLT reloc for symbol defined in shared library and accessed from executable (rebuild file with -fPIC ?) /opt/rh/devtoolset-10/root/usr/libexec/gcc/s390x-redhat-linux/10/ld: final link failed: bad value ```
Mic92
reviewed
Apr 29, 2023
.github/workflows/ci.yml
Outdated
| make -j$(nproc) check || (cat tests/test-suite.log; exit 1) | ||
| EOF | ||
|
|
||
| docker run -v $(pwd):/gha quay.io/pypa/manylinux2014_${{ matrix.platform }}:latest sh -ec "cd /gha && sh ./build.sh" |
There was a problem hiding this comment.
What would we need to upgrade to next year when centos 7 is EOL? https://wiki.centos.org/About/Product
There was a problem hiding this comment.
I think either ubuntu 18.04 or AlmaLinux 8 (/manylinux_2_28 which avoid installing a bunch of packages).
I could try to add it now to just be able to drop centos 7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards getting reproducers/non-regression tests for #492 which is OS dependent.