Do nothing if interpreter has not changed #512
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there is not change to the interpreter, don't make any modifications to the file. This is more efficient than requiring programs to check before changing, and also prevents thrashing of the ELF file, since changing the interpreter repeatedly will keep growing the ELF file each time, even if it's the same value. This is particularly helpful where the same binary is symlinked or hardlinked with multiple names and has patchelf run on it.
|
Duplicates #508 |
|
So it does |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is not change to the interpreter, don't make any modifications to the file. This is more efficient than requiring programs to check before changing, and also prevents thrashing of the ELF file, since changing the interpreter repeatedly will keep growing the ELF file each time, even if it's the same value.
This is particularly helpful where the same binary is symlinked or hardlinked with multiple names and has patchelf run on it.
Thank you!
Please do your best to include a regression test
so that the quality of future releases can be preserved.