Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Add option to modify the default configure_optimizers() behavior #1015

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

JQGoh
Copy link
Contributor

@JQGoh JQGoh commented May 23, 2024

Rationale

This shall deprecate the earlier work introduced in: #998

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jmoralez
Copy link
Member

Hey @JQGoh, thanks a lot for trying this approach! Although I think it's fine to add more arguments for now, we can give this a shot when we work towards v2.0.

@JQGoh
Copy link
Contributor Author

JQGoh commented May 23, 2024

Hey @JQGoh, thanks a lot for trying this approach! Although I think it's fine to add more arguments for now, we can give this a shot when we work towards v2.0.

In that case, I shall put this on hold then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants