Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

narrower modal titles when X button present #1219

Merged
merged 1 commit into from
Jan 4, 2023
Merged

narrower modal titles when X button present #1219

merged 1 commit into from
Jan 4, 2023

Conversation

ap-nri
Copy link
Contributor

@ap-nri ap-nri commented Jan 4, 2023

inspired by GRO-72

without button.

image

with button

image

@ap-nri ap-nri requested review from tesk9 and bendansby January 4, 2023 18:01
@linear
Copy link

linear bot commented Jan 4, 2023

GRO-72 Remove the semitransparent overlay over the text

Screen Shot 2021-12-07 at 12.08.22.png

tesk9
tesk9 approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@tesk9 tesk9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

bendansby
bendansby approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@bendansby bendansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our long translucent nightmare is over

@tesk9 tesk9 merged commit e58c6bf into master Jan 4, 2023
@tesk9 tesk9 deleted the growth/gro-72-keep-modal-titles-away-close-x branch January 4, 2023 23:52
@tesk9 tesk9 mentioned this pull request Jan 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bendansby bendansby bendansby approved these changes

@tesk9 tesk9 tesk9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ap-nri @tesk9 @bendansby