Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builds for debian #222

Merged

Conversation

AlexNDRmac
Copy link
Contributor

Hi @NoiseByNorthwest

I've reworked github actions to add Debian builds.
Now, github workflow split on two separate actions. It allows us to compile extension for ubuntu and macos, and build extension for Debian.
Debian users as an Ubuntu users - can download build extension and use it OOB (without compilation)

Also, I've updated Changelog, because it obsolete.

@NoiseByNorthwest
Copy link
Owner

Also, I've updated Changelog, because it obsolete.

Thanks for that, I forgot to update it myself in my previous patches. Is it easy to add a CI check in order to fail if the changelog is not updated ? And could this check be disabled when a particular PR label is set ?

@NoiseByNorthwest NoiseByNorthwest merged commit d245728 into NoiseByNorthwest:master Sep 2, 2023
28 checks passed
@NoiseByNorthwest
Copy link
Owner

Thanks @AlexNDRmac

@ilnytskyi
Copy link
Contributor

ilnytskyi commented Sep 12, 2023

@AlexNDRmac

Could describe new installation approach or update the installation section in README?
If I understand correctly now it's possible to just download spx.so file from releases and put it into extension_dir, if so it's a great improvement for distribution.

@AlexNDRmac
Copy link
Contributor Author

Yes, it's simplified profiler usage. Anyone who would like to profile some PHP application, now not requires to compile extension. Just download binary and assets from release and put in the right place.
But, as you should know - only spx.so is not enough. Also for profiling user should have own spx.ini with own configuration and process.dumpable enabled option for FPM on linux.
So, I don't know how to describe installation process changes :) I can suggest many questions from users who just put extension into extension_dir and got situation when nothing works :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants