PHP 5.4 support #227
Merged
PHP 5.4 support #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you also update the other places where php5.6 is mentioned as the minimum supported version ?
|
|
I looked for the string 5.6 and I found as you mentioned that only the test matrix and the README needed to be updated |
|
@Athorcis it looks like the debian+PHP5.4&5.5 cannot succeed, maybe these PHP versions are not supported on this image ? Can you confirm it and exclude them from debian variant ? |
|
@NoiseByNorthwest The problem is not Debian, but the repository https://packages.sury.org/php/ which doesn't support these versions. Should I exclude these versions from the Debian variant anyway ? |
|
@Athorcis Unless you know a workaround I think we should and that this is not a big issue. |
The repository packages.sury.org used to install PHP on Debian build doesn't support PHP 5.4 or 5.5. It's simpler to just exclude these versions as few users will use them anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #226