Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP8.4 support #270

Merged
merged 3 commits into from
Sep 29, 2024
Merged

Add PHP8.4 support #270

merged 3 commits into from
Sep 29, 2024

Conversation

NoiseByNorthwest
Copy link
Owner

No description provided.

@andypost
Copy link
Contributor

Looks strange that clang on MacOS fails

@NoiseByNorthwest
Copy link
Owner Author

Looks strange that clang on MacOS fails

Yes, but only with PHP8.4, @AlexNDRmac do you see what is the issue ? https://github.com/NoiseByNorthwest/php-spx/actions/runs/11092707280/job/30818091475?pr=270

@AlexNDRmac
Copy link
Contributor

Looks like compile issue. As I know, php core team trying to move from C99 to smth like C++ standard. Redefinition warning should be resolved with #ifndef or forward declaration... but, it's php :)
I'll try to sort out with it locally on mac.

@NoiseByNorthwest
Copy link
Owner Author

Looks like compile issue. As I know, php core team trying to move from C99 to smth like C++ standard. Redefinition warning should be resolved with #ifndef or forward declaration... but, it's php :)

Indeed, 8.4 introduces this dependency to C11+

~/dev/php-src [PHP-8.3 ↓·734|✔] 
23:09 $ ack 'typedef\s+struct\s+_zend_string\s+'
Zend/zend_types.h
96:typedef struct _zend_string     zend_string;~/dev/php-src [PHP-8.3 ↓·734|✔] 
23:09 $ git co PHP-8.4
Switched to branch 'PHP-8.4'
Your branch is up to date with 'origin/PHP-8.4'.
✔ ~/dev/php-src [PHP-8.4|✔] 
23:09 $ ack 'typedef\s+struct\s+_zend_string\s+'
Zend/zend_map_ptr.h
24:typedef struct _zend_string zend_string;

Zend/zend_types.h
96:typedef struct _zend_string     zend_string;

Zend/zend_smart_str_public.h
22:typedef struct _zend_string zend_string;

@NoiseByNorthwest NoiseByNorthwest force-pushed the php8.4-support branch 3 times, most recently from 34f97fd to 1cf9d65 Compare September 29, 2024 21:49
@NoiseByNorthwest NoiseByNorthwest merged commit 55fecc4 into master Sep 29, 2024
80 checks passed
@NoiseByNorthwest
Copy link
Owner Author

@AlexNDRmac fixed, I've just disabled "typedef-redefinition" warning on macOS.

@NoiseByNorthwest NoiseByNorthwest deleted the php8.4-support branch September 30, 2024 07:59
@nhutnguyenvu
Copy link

always get like that for the latest/release branch
Configuring for:
PHP Api Version: 20220829
Zend Module Api No: 20220829
Zend Extension Api No: 420220829

@NoiseByNorthwest
Copy link
Owner Author

NoiseByNorthwest commented Oct 4, 2024

@nhutnguyenvu your PHP version seems to be 8.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants