Update health slider using progress bar #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was partially implemented in ee0a6f3 and I prefer it to be a simple mesh as it currently is rather than a subviewport for the performance impact of it and that is less prone to errors. Thanks for your effort but I would prefer having the simple mesh. |
|
No worries, in order to save time for future contributors, can you please close #11 or at least add information of which parts of it is implemented and which parts are not planned to be implemented. |
|
Sure, I'll try to improve my communication in the future, sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated the health slider to use a progress bar. Now, the health slider is implemented as specified in #11 , with a grey bar behind the health bar showing the full health of the target.