Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support allow_paths in foundry.toml #476

Closed
kanej opened this issue May 1, 2023 · 1 comment · Fixed by #477
Closed

Support allow_paths in foundry.toml #476

kanej opened this issue May 1, 2023 · 1 comment · Fixed by #477
Labels
status:ready This issue is ready to be worked on

Comments

@kanej
Copy link
Member

kanej commented May 1, 2023

This issue was raised on discord: https://discord.com/channels/750408878008827925/951537942239797338/1101880603701420083

A cli run of forge gives no errors but it fails in the vscode extension with the following setup:

image

I suspect this is that the Foundry adapter is not reading and using allow_paths.
@kanej kanej added status:ready This issue is ready to be worked on and removed status:triaging labels May 1, 2023
@kanej kanej moved this to Todo in hardhat-vscode May 1, 2023
@antico5 antico5 mentioned this issue May 2, 2023
Merged
@kanej kanej closed this as completed in #477 May 3, 2023
kanej pushed a commit that referenced this issue May 3, 2023
@antico5
fix: support absolute path remappings on foundry projects (#477)
5823739 
Replaced path.join with path.resolve when parsing remappings to allow for absolute path remappings.

Fixes #476
@github-project-automation github-project-automation bot moved this from Todo to Done in hardhat-vscode May 3, 2023
@kanej
Copy link
Member Author

kanej commented May 3, 2023

The issue here was our processing of remappings rather than allow_paths, we now deal better with absolute paths in this case.

@kanej kanej mentioned this issue May 3, 2023
Merged
kanej pushed a commit that referenced this issue May 3, 2023
@antico5 @kanej
fix: support absolute path remappings on foundry projects (#477)
0bffc69 
Replaced path.join with path.resolve when parsing remappings to allow for absolute path remappings.

Fixes #476
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:ready This issue is ready to be worked on
Projects
hardhat-vscode
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: support absolute path remappings on foundry projects NomicFoundation/hardhat-vscode
1 participant
@kanej