update logo and title #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #311 +/- ##
==============================================
Coverage ? 57.63%
==============================================
Files ? 174
Lines ? 4329
Branches ? 706
==============================================
Hits ? 2495
Misses ? 1603
Partials ? 231 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
antico5
approved these changes
Dec 19, 2022
kanej
force-pushed
the
chore/update-logo-and-title
branch
from
4472d3a
to
046c76d
Compare
Use the new logo for the extension in the extension metadata - this will get reflected in the marketplace.
Remove the out of date internal docs references to **Hardhat for VSCode**. The extension is now generally Solidity focused which is reflected in our name change to **Solidity**. As there are other **Solidity** extensions we disambiguate in our marketplace facing documentation with **Solidity by Nomic Foundation**. Outside of the marketplace we use **Solidity for VS Code by Nomic Foundation** to give context that it is the vscode extension that we are talking about.
The extension is providing general solidity features and is now called `Solidity`, but in many places we were calling the extension `Hardhat for VSCode`, or using hardhat naming. This commit, changes the name to solidity: * rename the output channels to `solidity` * update commands/tasks with some `solidity` renames (we kept some hardhat for hardhat tasks) * rename the Settings section to `solidity`
kanej
force-pushed
the
chore/update-logo-and-title
branch
from
046c76d
to
a595375
Compare
|
This LGTM. I don't have a strong preference between VS Code or VSCode tbh. |
alcuadrado
approved these changes
Dec 21, 2022
Merged
kanej
added a commit
that referenced
this pull request
Dec 22, 2022
* chore: update extension logo Use the new logo for the extension in the extension metadata - this will get reflected in the marketplace. * docs: update way extension is referred to Remove the out of date internal docs references to **Hardhat for VSCode**. The extension is now generally Solidity focused which is reflected in our name change to **Solidity**. As there are other **Solidity** extensions we disambiguate in our marketplace facing documentation with **Solidity by Nomic Foundation**. Outside of the marketplace we use **Solidity for VS Code by Nomic Foundation** to give context that it is the vscode extension that we are talking about. * feat: switch to solidity naming The extension is providing general solidity features and is now called `Solidity`, but in many places we were calling the extension `Hardhat for VSCode`, or using hardhat naming. This commit, changes the name to solidity: * rename the output channels to `solidity` * update commands/tasks with some `solidity` renames (we kept some hardhat for hardhat tasks) * rename the Settings section to `solidity`
kanej
added a commit
that referenced
this pull request
Dec 22, 2022
* chore: update extension logo Use the new logo for the extension in the extension metadata - this will get reflected in the marketplace. * docs: update way extension is referred to Remove the out of date internal docs references to **Hardhat for VSCode**. The extension is now generally Solidity focused which is reflected in our name change to **Solidity**. As there are other **Solidity** extensions we disambiguate in our marketplace facing documentation with **Solidity by Nomic Foundation**. Outside of the marketplace we use **Solidity for VS Code by Nomic Foundation** to give context that it is the vscode extension that we are talking about. * feat: switch to solidity naming The extension is providing general solidity features and is now called `Solidity`, but in many places we were calling the extension `Hardhat for VSCode`, or using hardhat naming. This commit, changes the name to solidity: * rename the output channels to `solidity` * update commands/tasks with some `solidity` renames (we kept some hardhat for hardhat tasks) * rename the Settings section to `solidity`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have renamed the extension from
Hardhat for VS CodetoSolidityto reflect the general solidity features we are providing. However there were places in docs/readme/internal features that are using the old naming.Preview
This PR:
Solidity by Nomic FoundationHardhattoSoliditysoliditysolidityrenames (we kept somehardhat for hardhat tasks)