-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Natspec completions #359
Natspec completions #359
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great.
I have pinged the channel to confirm people are happy with the suggestion we are making to users.
Reading through the spec I suspect we need to support completions on ///
comments as well. Does that require a different approach?
I think we can achieve that with some small adaptation. Should I add that to this PR? |
Yes, lets add that to the requirement. |
@kanej triple forward slash format is implemented! ready to re-review |
Based on feedback can we change: function
Contract/Library/InterfaceEventState Variable
Public state variableCan we check that the gif matches this version? |
@kanej ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested and generated docs from the defaults using solc: https://docs.soliditylang.org/en/latest/natspec-format.html#documentation-output.
I am approving, but can I request one change which is that public state variables should not default to @dev, just @notice.
* feat: automatic natspec documentation * tests for natspec completion * add natspec completion gif to readme * add tab-jumping and return param name * feat: natspec completion for contracts, interfaces and libraries * feat: natspec completion for state vars and events * feat: natspec triple slash completion * fix: update logic on natspec generation * fix: show either @notice or @dev on state variables
closes #342
closes #343
closes #296
This one is branched off a rebased version of PR #328