Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: server document formatting #429

Merged
merged 4 commits into from
Apr 12, 2023
Merged

Conversation

antico5
Copy link
Collaborator

@antico5 antico5 commented Mar 15, 2023

  • Removed all formatting related code from client
  • Added textDocument/formatting handling on the server
  • Adapted/fixed the formatting logic to work on the server side properly
  • Added extension config sync between client and server, since config is not naturally available from the server
  • Tested and added some docs for coc-solidity
  • Protocol tests for all formatting providers

Closes #300

@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2023

Codecov Report

❗ No coverage uploaded for pull request base (development@391baa4). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 4380ae5 differs from pull request most recent head 606e19a. Consider uploading reports for the commit 606e19a to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@              Coverage Diff               @@
##             development     #429   +/-   ##
==============================================
  Coverage               ?   55.24%           
==============================================
  Files                  ?      179           
  Lines                  ?     4545           
  Branches               ?      750           
==============================================
  Hits                   ?     2511           
  Misses                 ?     1798           
  Partials               ?      236           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

client/src/setup/setupLanguageServerHooks.ts Show resolved Hide resolved
coc/README.md Outdated Show resolved Hide resolved
Copy link
Member

@kanej kanej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kanej kanej force-pushed the move_formatting_to_server branch from fa3d1f0 to c0b9a63 Compare April 12, 2023 10:35
@antico5 antico5 merged commit 1dd334e into development Apr 12, 2023
@antico5 antico5 deleted the move_formatting_to_server branch April 12, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Move formatting to server side
3 participants