Merge pull request #564 from nomiclabs/fix-plugin-dependencies-valida…

…tion Make plugins dependency validation accept prerelease versions
NomicFoundation · May 9, 2020 · 3ba7dd6 · 3ba7dd6
2 parents 953f8be + 9d21f6f
commit 3ba7dd6
Show file tree

Hide file tree

Showing 6 changed files with 27 additions and 1 deletion.
diff --git a/packages/buidler-core/src/internal/core/plugins.ts b/packages/buidler-core/src/internal/core/plugins.ts
@@ -99,7 +99,11 @@ export function usePlugin(
 
       const installedVersion = dependencyPackageJson.version;
 
-      if (!semver.satisfies(installedVersion, versionSpec)) {
+      if (
+        !semver.satisfies(installedVersion, versionSpec, {
+          includePrerelease: true,
+        })
+      ) {
         throw new BuidlerError(ERRORS.PLUGINS.DEPENDENCY_VERSION_MISMATCH, {
           plugin: pluginName,
           dependency: dependencyName,

diff --git a/...uidler-core/test/fixture-projects/plugin-loading-project/node_modules/prerelease/index.js b/...uidler-core/test/fixture-projects/plugin-loading-project/node_modules/prerelease/index.js
diff --git a/...er-core/test/fixture-projects/plugin-loading-project/node_modules/prerelease/package.json b/...er-core/test/fixture-projects/plugin-loading-project/node_modules/prerelease/package.json
diff --git a/...re/test/fixture-projects/plugin-loading-project/node_modules/requires-prerelease/index.js b/...re/test/fixture-projects/plugin-loading-project/node_modules/requires-prerelease/index.js
diff --git a/...est/fixture-projects/plugin-loading-project/node_modules/requires-prerelease/package.json b/...est/fixture-projects/plugin-loading-project/node_modules/requires-prerelease/package.json
diff --git a/packages/buidler-core/test/internal/core/plugins.ts b/packages/buidler-core/test/internal/core/plugins.ts
@@ -127,6 +127,11 @@ describe("plugin system", function () {
       assert.isTrue(globalAsAny.loaded);
     });
 
+    it("Should load a plugin if with a prerelease version of a dependency", function () {
+      usePlugin(ctx, "requires-prerelease", projectPath);
+      assert.isTrue(globalAsAny.loaded);
+    });
+
     it("Should fail if a peer dependency is missing", function () {
       expectBuidlerError(
         () => usePlugin(ctx, "requires-missing-pack", projectPath),