Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttpProxy envs while interacting with networks #1979

Closed

Conversation

furkilic
Copy link

  • Because this PR includes a new feature, it uses the development branch as its base branch.

Being behind a Corporate HttpProxy, I'd like to add the feature to deploy/interact with networks by using standard environment variables : HTTPS_PROXY or HTTP_PROXY .

Linked to #1978

@changeset-bot
Copy link

changeset-bot bot commented Oct 22, 2021

⚠️ No Changeset found

Latest commit: 5944a9e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Nov 4, 2021

CLA assistant check
All committers have signed the CLA.

@fvictorio fvictorio deleted the branch NomicFoundation:master November 5, 2021 19:16
@fvictorio fvictorio closed this Nov 5, 2021
@fvictorio fvictorio reopened this Nov 5, 2021
@fvictorio
Copy link
Member

Hey @furkilic, could you rebase this to use the master branch instead?

@furkilic furkilic changed the base branch from development to master November 5, 2021 19:44
@furkilic furkilic force-pushed the deploy-behind-corporate-proxy branch from 424f849 to 2dee5e2 Compare November 5, 2021 20:12
@furkilic
Copy link
Author

furkilic commented Nov 5, 2021

Hi @fvictorio
Tried to do it though the UI first but failed miserably
The rebase should be ok now

@suil
Copy link

suil commented Mar 5, 2022

any updates on this?

@Vallsurf
Copy link

Anything blocking from this being merged? Would be a huge help.

@github-actions
Copy link
Contributor

This PR was marked as stale because it didn't have any activity in the last 30 days. Please excuse us if we didn't have enough time to review it and get it merged. If you are still interested in getting these changes applied, please leave a comment indicating so. Otherwise, it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jul 15, 2022
@github-actions
Copy link
Contributor

This PR was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this Jul 22, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the ability to deploy to networks behind a Corporate HttpProxy
6 participants