Return block in callbackified blockchain #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fvictorio
commented
Nov 3, 2020
| @@ -1,2 +1 @@ | |||
| export type Callback<T = void> = ((error: NonNullable<any>) => void) & | |||
| ((error: null | undefined, value: T) => void); | |||
| export type Callback<T = void> = (error: any, value: T) => void; | |||
There was a problem hiding this comment.
This is the type change that triggers all the other typescript changes. This makes sense to me, but I have no idea what I'm doing.
fvictorio
commented
Nov 3, 2020
| const genesis = createBlock(0); | ||
| const one = createBlock(1); | ||
| await promisify<Block>(callbackifiedBlockchain.putBlock)(genesis); | ||
| await promisify<Block>(callbackifiedBlockchain.putBlock)(one); |
There was a problem hiding this comment.
This is ugly, I'd rather have a promisifiedCallbackifiedBlockchain (without that name, I swear) and just duplicate the previous test as is.
fvictorio
commented
Nov 3, 2020
| @@ -146,6 +176,34 @@ describe("HardhatBlockchain", () => { | |||
| assert.equal(await blockchain.getBlock(blockThree.hash()), undefined); | |||
| }); | |||
|
|
|||
| it.skip("removes the block and all subsequent ones (callbackified)", async () => { | |||
There was a problem hiding this comment.
This test is a duplicated version of the previous one, like the other added tests. But this one fails because of this line:
I don't know if that line is fine, and so this tests needs to be different, or if that undefined check should be removed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is literally one line, but I also modified a bunch of typescript stuff to make typescript detect the previous issue. I'm not sure at all about those changes.
I also added some minimal tests for the callbackified version of the
Blockchainclass. One of them is skipped for reasons I will explain in the comments.