Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allocatable tracer array #113

Merged
merged 4 commits into from
Sep 21, 2021
Merged

Allocatable tracer array #113

merged 4 commits into from
Sep 21, 2021

Conversation

TomasTorsvik
Copy link
Contributor

This is a suggestion for changing the tracer array from static to allocatable. I have also moved some things around in the module, but this doesn't make any difference for the final outcome.

@TomasTorsvik TomasTorsvik added the enhancement New feature or request label Sep 14, 2021
@TomasTorsvik TomasTorsvik self-assigned this Sep 14, 2021
@TomasTorsvik TomasTorsvik linked an issue Sep 14, 2021 that may be closed by this pull request
Enable tracer count to be determined at run time #105
Closed
@TomasTorsvik
Copy link
Contributor Author

TomasTorsvik commented Sep 15, 2021 •
edited
Loading

From #105 (comment) :

Here are results from some tests I did on Betzy and Fram:
alloc_array_perf.txt

It seems that there still can be some issues when replacing static arrays with allocatable ones, but perhaps only for specific compiler settings or case parameters. For most tests the differences were fairly small.

@JorgSchwinger
Copy link
Contributor

I don't know why, but github won't let me add an review.

So I just coment here: looks good to me, I would be fine with including this.

JorgSchwinger
JorgSchwinger approved these changes Sep 17, 2021
View reviewed changes
Copy link
Contributor

@JorgSchwinger JorgSchwinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, now it works...

@TomasTorsvik
Copy link
Contributor Author

It turns out that the code runs with call xcbcst(ntr) even if ntr is declared protected, so I removed the num_tracers variable. I also ran the fuk95 case without problems from the branch.

@TomasTorsvik TomasTorsvik merged commit f446bc4 into NorESMhub:master Sep 21, 2021
@TomasTorsvik TomasTorsvik deleted the allocatable_tracer_array branch September 21, 2021 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorgSchwinger JorgSchwinger JorgSchwinger approved these changes

@matsbn matsbn Awaiting requested review from matsbn

@milicak milicak Awaiting requested review from milicak

@AleksiNummelin AleksiNummelin Awaiting requested review from AleksiNummelin

Assignees

@TomasTorsvik TomasTorsvik

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable tracer count to be determined at run time
2 participants
@TomasTorsvik @JorgSchwinger