Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hamocc fix restart file units #239

Merged
merged 3 commits into from
Feb 14, 2023

Conversation

jmaerz
Copy link
Collaborator

@jmaerz jmaerz commented Feb 14, 2023

Hi @TomasTorsvik and @JorgSchwinger , I prepared a fix for the units in the restart file as suggested in #238. I noticed that the particulate materials were all in X/m2, while I believe it should read X/m3 and changed this as well. Of course, for the burial layer, it should stay with X/m2. Closes #238

@jmaerz jmaerz added the iHAMOCC Issue mainly concerns the iHAMOCC code base label Feb 14, 2023
@jmaerz jmaerz self-assigned this Feb 14, 2023
Copy link
Contributor

@JorgSchwinger JorgSchwinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing this!

Copy link
Contributor

@TomasTorsvik TomasTorsvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@jmaerz jmaerz merged commit 7f83308 into NorESMhub:master Feb 14, 2023
@jmaerz jmaerz deleted the hamocc-fix-restart-file-units branch February 14, 2023 15:21
jmaerz added a commit that referenced this pull request Feb 15, 2023
String counter adjusted to fit changed restart file units in #239.
jmaerz added a commit to jmaerz/BLOM that referenced this pull request Aug 9, 2023
* fixes for restart units as suggested

* fix restart units for sediment restart file

* fix indention of line &
jmaerz added a commit to jmaerz/BLOM that referenced this pull request Aug 9, 2023
String counter adjusted to fit changed restart file units in NorESMhub#239.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iHAMOCC Issue mainly concerns the iHAMOCC code base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Units in iHAMOCC restart file
3 participants