Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file mo_boxatm.F90 #265

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Add file mo_boxatm.F90 #265

merged 2 commits into from
Aug 3, 2023

Conversation

JorgSchwinger
Copy link
Contributor

making it possible to run HAMOCC with a well-mixed 1D box atmosphere for air-sea exchange of CO2 (and C-isotopes). There is currently no way to activate this option other than adding the preprocessor flag -DBOXATM in cime_config/buildcpp.

I have tested that it compiles and runs as expected (bit-for-bit if BOXATM is deactivated). Results with BOXATM look reasonable, but are not validated beyond this.

…ixed 1D box atmosphere for air-sea exchange of CO2 (and C-isotopes). There is currently no way to activate this option other than adding the preprocessor flag -DBOXATM in cime_config/buildcpp.
@JorgSchwinger
Copy link
Contributor Author

JorgSchwinger commented Aug 2, 2023

When testing compiling with C-isotopes and BOXATM I encountered (some of) the same errors as @mvertens in #264. I did not include fixes to this errors in this PR to avoid later conflicts when merging in #264

Copy link
Contributor

@TomasTorsvik TomasTorsvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JorgSchwinger - Thanks for including the missing module.

@TomasTorsvik TomasTorsvik added the iHAMOCC Issue mainly concerns the iHAMOCC code base label Aug 2, 2023
Copy link
Collaborator

@jmaerz jmaerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JorgSchwinger , also thanks from my side. I think, the file needs to be added to ./hamocc/meson.build to make it accessible to 1D setups. After this, approved.

@jmaerz jmaerz mentioned this pull request Aug 2, 2023
Copy link
Contributor

@mvertens mvertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR.

@JorgSchwinger JorgSchwinger merged commit 4930ba4 into NorESMhub:master Aug 3, 2023
10 checks passed
@JorgSchwinger JorgSchwinger deleted the feature-add_boxatm branch August 3, 2023 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iHAMOCC Issue mainly concerns the iHAMOCC code base
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants